Issue 384983002: Count external PDF viewer usage in print preview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384983002: Count external PDF viewer usage in print preview. (Closed)

Created:
6 years, 5 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 5 months ago

Reviewers:
Aleksey Shlyapnikov, Noam Samuel, Ilya Sherman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Count external PDF viewer usage in print preview. BUG=393024 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282516

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View	2	2 chunks	+7 lines, -0 lines	0 comments	Download
	M	tools/metrics/histograms/histograms.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

Vitaly Buka (NO REVIEWS)

The CQ bit was checked by vitalybuka@chromium.org

6 years, 5 months ago (2014-07-10 23:23:56 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/384983002/40001

6 years, 5 months ago (2014-07-10 23:24:48 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-11 02:49:59 UTC) #7

Message was sent while issue was closed.

Change committed as 282516