Introduce disable-gaia-services for fake telemetry login.

Introduce disable-gaia-services for fake telemetry login.

oobe-skip-postlogin has been overloaded and it does a lot more than just suppress the postlogin screens.

We need session restore/merge and enrollment for gaia login, but not for fake telemetry login.

BUG=393011
TEST=manual
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283594

[achuithb, 2014-07-11 00:02:45]

Please review, Nikita.

[Nikita (slow), 2014-07-14 09:32:59]

lgtm

https://codereview.chromium.org/384973004/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc
(right):

https://codereview.chromium.org/384973004/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc:100: if
(command_line->HasSwitch(chromeos::switches::kDisableSessionRestore) ||
I seems like you should use a different flag here since now
--disable-session-restore will be responsible for OAuth session restore as well
as auto enrollment.

Alternatively you can rename this flag.

https://codereview.chromium.org/384973004/diff/1/chromeos/chromeos_switches.cc
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/384973004/diff/1/chromeos/chromeos_switches.c...
chromeos/chromeos_switches.cc:187: // Disable session restore. Used by 'fake'
telemetry login.
nit: Disable OAuth session restore.

[achuithb, 2014-07-16 20:00:52]

Thanks!

https://codereview.chromium.org/384973004/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc
(right):

https://codereview.chromium.org/384973004/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc:100: if
(command_line->HasSwitch(chromeos::switches::kDisableSessionRestore) ||
On 2014/07/14 09:32:59, Nikita Kostylev wrote:
> I seems like you should use a different flag here since now
> --disable-session-restore will be responsible for OAuth session restore as
well
> as auto enrollment.
> 
> Alternatively you can rename this flag.

Renamed to kDisableGaiaServices.

https://codereview.chromium.org/384973004/diff/1/chromeos/chromeos_switches.cc
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/384973004/diff/1/chromeos/chromeos_switches.c...
chromeos/chromeos_switches.cc:187: // Disable session restore. Used by 'fake'
telemetry login.
On 2014/07/14 09:32:59, Nikita Kostylev wrote:
> nit: Disable OAuth session restore.

Done.

[achuithb, 2014-07-16 20:01:07]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-07-16 20:04:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/achuith@chromium.org/384973004/20001

[commit-bot: I haz the power, 2014-07-16 23:31:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[achuithb, 2014-07-17 00:02:12]

The CQ bit was unchecked by achuith@chromium.org

[achuithb, 2014-07-17 00:02:25]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-07-17 00:05:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/achuith@chromium.org/384973004/20001

[commit-bot: I haz the power, 2014-07-17 00:28:20]

Change committed as 283594