Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 384973002: Windows: Find the correct path to Adobe Reader. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Windows: Find the correct path to Adobe Reader. BUG=370746 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282527

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/pdf/adobe_reader_info_win.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
6 years, 5 months ago (2014-07-10 22:58:33 UTC) #1
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/384973002/diff/1/chrome/browser/ui/pdf/adobe_reader_info_win.cc File chrome/browser/ui/pdf/adobe_reader_info_win.cc (right): https://codereview.chromium.org/384973002/diff/1/chrome/browser/ui/pdf/adobe_reader_info_win.cc#newcode62 chrome/browser/ui/pdf/adobe_reader_info_win.cc:62: return filepath; lgtm but I suggest return filepath.Append(app);
6 years, 5 months ago (2014-07-10 23:50:27 UTC) #2
Lei Zhang
https://codereview.chromium.org/384973002/diff/1/chrome/browser/ui/pdf/adobe_reader_info_win.cc File chrome/browser/ui/pdf/adobe_reader_info_win.cc (right): https://codereview.chromium.org/384973002/diff/1/chrome/browser/ui/pdf/adobe_reader_info_win.cc#newcode62 chrome/browser/ui/pdf/adobe_reader_info_win.cc:62: return filepath; On 2014/07/10 23:50:26, cpu wrote: > lgtm ...
6 years, 5 months ago (2014-07-11 00:06:18 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-11 00:06:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/384973002/20001
6 years, 5 months ago (2014-07-11 00:07:56 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 03:32:20 UTC) #6
Message was sent while issue was closed. 
Change committed as 282527

Powered by Google App Engine
This is Rietveld 408576698