ES6 Unscopables

test/mjsunit/harmony/proxies-with-unscopables.js

Index: test/mjsunit/harmony/proxies-with-unscopables.js
diff --git a/test/mjsunit/harmony/proxies-with-unscopables.js b/test/mjsunit/harmony/proxies-with-unscopables.js
new file mode 100644
index 0000000000000000000000000000000000000000..7da570fb252cfe6e4753530154da6011bd1e248f
--- /dev/null
+++ b/test/mjsunit/harmony/proxies-with-unscopables.js
@@ -0,0 +1,93 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --harmony-unscopables
+// Flags: --harmony-proxies

[rossberg, 2014/07/17 15:12:13]

Hm, shouldn't there also be some tests that actually define @@unscopables on a
proxy, and one that uses a proxy as @@unscopables?

[arv (Not doing code reviews), 2014/07/17 23:34:36]

Like I said in a comment on the CL. Proxies cannot have symbols as property
names.

I'll add a TODO.

+
+
+(function TestBasics() {
+  var log = [];
+
+  var proxy = Proxy.create({
+    getPropertyDescriptor: function(key) {
+      log.push(key);
+      if (key === 'x') {
+        return {
+          value: 1,
+          configurable: true
+        };
+      }
+      return undefined;
+    }
+  });
+
+  var x = 'local';
+
+  with (proxy) {
+    assertEquals(1, x);
+  }
+
+  // One 'x' for HasBinding and two for GetBindingValue
+  assertEquals(['assertEquals', 'x', 'x', 'x'], log);
+})();
+
+
+(function TestInconsistent() {
+  var log = [];
+  var calls = 0;
+
+  var proxy = Proxy.create({
+    getPropertyDescriptor: function(key) {
+      log.push(key);
+      if (key === 'x' && calls < 2) {
+        calls++;
+        return {
+          value: 1,
+          configurable: true
+        };
+      }
+      return undefined;
+    }
+  });
+
+  var x = 'local';
+
+  with (proxy) {
+    assertEquals(void 0, x);
+  }
+
+  // One 'x' for HasBinding and two for GetBindingValue
+  assertEquals(['assertEquals', 'x', 'x', 'x'], log);
+})();
+
+
+(function TestInconsistent2() {
+  var log = [];
+  var calls = 0;
+
+  var proxy = Proxy.create({
+    getPropertyDescriptor: function(key) {
+      log.push(key);
+      if (key === 'x' && calls < 1) {
+        calls++;
+        return {
+          value: 1,
+          configurable: true
+        };
+      }
+      return undefined;
+    }
+  });
+
+  var x = 'local';
+
+  with (proxy) {
+    assertEquals(void 0, x);
+  }
+
+  // One 'x' for HasBinding and one for GetBindingValue, the second one from
+  // previous test is not called since the proxy reported that there is no 'x'
+  // property when we did GetBindingValue.
+  assertEquals(['assertEquals', 'x', 'x'], log);
+})();