Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/objects-inl.h

Issue 384963002: ES6 Unscopables (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 1128 matching lines...) Expand 10 before | Expand all | Expand 10 after
1139 Handle<String> str = isolate->factory()->InternalizeUtf8String(name); 1139 Handle<String> str = isolate->factory()->InternalizeUtf8String(name);
1140 ASSERT(!str.is_null()); 1140 ASSERT(!str.is_null());
1141 #ifdef DEBUG 1141 #ifdef DEBUG
1142 uint32_t index; // Assert that the name is not an array index. 1142 uint32_t index; // Assert that the name is not an array index.
1143 ASSERT(!str->AsArrayIndex(&index)); 1143 ASSERT(!str->AsArrayIndex(&index));
1144 #endif // DEBUG 1144 #endif // DEBUG
1145 return GetProperty(object, str); 1145 return GetProperty(object, str);
1146 } 1146 }
1147 1147
1148 1148
1149 MaybeHandle<Object> Object::GetPropertyWithReceiver(Handle<JSReceiver> holder,
rossberg 2014/07/11 11:59:06 I'd prefer to inline this function, it doesn't see
arv (Not doing code reviews) 2014/07/11 21:47:28 Done.
1150 Handle<Object> receiver,
1151 Handle<Name> name) {
1152 LookupIterator it(receiver, name, holder);
1153 return GetProperty(&it);
1154 }
1155
1156
1149 MaybeHandle<Object> JSProxy::GetElementWithHandler(Handle<JSProxy> proxy, 1157 MaybeHandle<Object> JSProxy::GetElementWithHandler(Handle<JSProxy> proxy,
1150 Handle<Object> receiver, 1158 Handle<Object> receiver,
1151 uint32_t index) { 1159 uint32_t index) {
1152 return GetPropertyWithHandler( 1160 return GetPropertyWithHandler(
1153 proxy, receiver, proxy->GetIsolate()->factory()->Uint32ToString(index)); 1161 proxy, receiver, proxy->GetIsolate()->factory()->Uint32ToString(index));
1154 } 1162 }
1155 1163
1156 1164
1157 MaybeHandle<Object> JSProxy::SetElementWithHandler(Handle<JSProxy> proxy, 1165 MaybeHandle<Object> JSProxy::SetElementWithHandler(Handle<JSProxy> proxy,
1158 Handle<JSReceiver> receiver, 1166 Handle<JSReceiver> receiver,
(...skipping 6011 matching lines...) Expand 10 before | Expand all | Expand 10 after
7170 #undef READ_SHORT_FIELD 7178 #undef READ_SHORT_FIELD
7171 #undef WRITE_SHORT_FIELD 7179 #undef WRITE_SHORT_FIELD
7172 #undef READ_BYTE_FIELD 7180 #undef READ_BYTE_FIELD
7173 #undef WRITE_BYTE_FIELD 7181 #undef WRITE_BYTE_FIELD
7174 #undef NOBARRIER_READ_BYTE_FIELD 7182 #undef NOBARRIER_READ_BYTE_FIELD
7175 #undef NOBARRIER_WRITE_BYTE_FIELD 7183 #undef NOBARRIER_WRITE_BYTE_FIELD
7176 7184
7177 } } // namespace v8::internal 7185 } } // namespace v8::internal
7178 7186
7179 #endif // V8_OBJECTS_INL_H_ 7187 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | test/mjsunit/harmony/unscopables.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698