Add file access modes to sk_exists.

Add file access modes to sk_exists.

Both Windows and Posix 'access' calls take a mode parameter which,
in addition to checking existence, checks access modes.
This change exposes this functionality.

Committed: https://skia.googlesource.com/skia/+/bf0b9ced0b93d9684b044e0880691768f9aa4394

[bungeman-skia, 2014-07-10 20:53:45]

The motivation for this is to get the last platform specific calls out of the
FontConfig code. This will be used in a soon to be uploaded CL.

[reed1, 2014-07-10 21:03:02]

lgtm

[mtklein, 2014-07-10 21:03:30]

https://codereview.chromium.org/384903002/diff/1/include/core/SkOSFile.h
File include/core/SkOSFile.h (right):

https://codereview.chromium.org/384903002/diff/1/include/core/SkOSFile.h#newc...
include/core/SkOSFile.h:80: // Returns true if something (file, directory, ???)
exists at this path.
// If flags is set, only return true if that something supports that mode.

Or some sort of comment reminding us what the flags argument does?

https://codereview.chromium.org/384903002/diff/1/src/ports/SkOSFile_stdio.cpp
File src/ports/SkOSFile_stdio.cpp (right):

https://codereview.chromium.org/384903002/diff/1/src/ports/SkOSFile_stdio.cpp...
src/ports/SkOSFile_stdio.cpp:127: int mode = 0;
  // F_OK
?

[mtklein, 2014-07-10 21:03:56]

On 2014/07/10 21:03:30, mtklein wrote:
> https://codereview.chromium.org/384903002/diff/1/include/core/SkOSFile.h
> File include/core/SkOSFile.h (right):
> 
>
https://codereview.chromium.org/384903002/diff/1/include/core/SkOSFile.h#newc...
> include/core/SkOSFile.h:80: // Returns true if something (file, directory,
???)
> exists at this path.
> // If flags is set, only return true if that something supports that mode.
> 
> Or some sort of comment reminding us what the flags argument does?
> 
> https://codereview.chromium.org/384903002/diff/1/src/ports/SkOSFile_stdio.cpp
> File src/ports/SkOSFile_stdio.cpp (right):
> 
>
https://codereview.chromium.org/384903002/diff/1/src/ports/SkOSFile_stdio.cpp...
> src/ports/SkOSFile_stdio.cpp:127: int mode = 0;
>   // F_OK
> ?

lgtm

[bungeman-skia, 2014-07-10 21:50:07]

https://codereview.chromium.org/384903002/diff/1/include/core/SkOSFile.h
File include/core/SkOSFile.h (right):

https://codereview.chromium.org/384903002/diff/1/include/core/SkOSFile.h#newc...
include/core/SkOSFile.h:80: // Returns true if something (file, directory, ???)
exists at this path.
On 2014/07/10 21:03:30, mtklein wrote:
> // If flags is set, only return true if that something supports that mode.
> 
> Or some sort of comment reminding us what the flags argument does?

Done.

https://codereview.chromium.org/384903002/diff/1/src/ports/SkOSFile_stdio.cpp
File src/ports/SkOSFile_stdio.cpp (right):

https://codereview.chromium.org/384903002/diff/1/src/ports/SkOSFile_stdio.cpp...
src/ports/SkOSFile_stdio.cpp:127: int mode = 0;
On 2014/07/10 21:03:30, mtklein wrote:
>   // F_OK
> ?

Done.

[bungeman-skia, 2014-07-10 21:52:37]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-07-10 21:52:50]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/384903002/40001

[commit-bot: I haz the power, 2014-07-10 22:18:26]

Change committed as bf0b9ced0b93d9684b044e0880691768f9aa4394