Issue 384893002: Add #ifdefs for the extensions parts of SupervisedUserService.

Issue 384893002: Add #ifdefs for the extensions parts of SupervisedUserService. (Closed)

Created:
6 years, 5 months ago by Lei Zhang

Modified:
6 years, 5 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add #ifdefs for the extensions parts of SupervisedUserService. BUG=349436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282709

Patch Set 1 : #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -39 lines)			Patch
	M	chrome/browser/supervised_user/supervised_user_service.h	View		8 chunks	+18 lines, -4 lines	0 comments	Download
	M	chrome/browser/supervised_user/supervised_user_service.cc	View		14 chunks	+54 lines, -35 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

LGTM, but is there a bug for this, so we can follow along at home? ...

6 years, 5 months ago (2014-07-11 10:50:02 UTC) #2

Lei Zhang

Added a bug #. https://codereview.chromium.org/384893002/diff/20001/chrome/browser/supervised_user/supervised_user_service.cc File chrome/browser/supervised_user/supervised_user_service.cc (right): https://codereview.chromium.org/384893002/diff/20001/chrome/browser/supervised_user/supervised_user_service.cc#newcode49 chrome/browser/supervised_user/supervised_user_service.cc:49: #if defined(OS_CHROMEOS) On 2014/07/11 10:50:02, ...

6 years, 5 months ago (2014-07-11 19:33:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/384893002/20001

6 years, 5 months ago (2014-07-11 19:34:22 UTC) #5

Message was sent while issue was closed.

Change committed as 282709

Expand Messages | Collapse Messages