net/socket/socket_test_util.h - Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socket_test_util.h

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop

Patch Set: Removed FormatSessionCacheKey function. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socket_test_util.h

diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h

index aa5ef1c762a88c32504b4aa503583b79d03a5dfd..4bff2d4999036342a417b41be7aae746cad3fe2d 100644

--- a/net/socket/socket_test_util.h

+++ b/net/socket/socket_test_util.h

@@ -704,6 +704,7 @@ class MockClientSocket : public SSLClientSocket {

virtual void SetOmniboxSpeculation() OVERRIDE {}

// SSLClientSocket implementation.

+ virtual std::string GetSessionCacheKey() const OVERRIDE;

virtual bool InSessionCache() const OVERRIDE;

virtual void WatchSessionForCompletion(const base::Closure& cb) OVERRIDE;

virtual void SetSocketFailureCallback(const base::Closure& cb) OVERRIDE;

« no previous file with comments | « net/socket/client_socket_pool_base_unittest.cc ('k') | net/socket/socket_test_util.cc » ('j') | net/socket/socket_test_util.cc » ('J')