net/socket/ssl_client_socket_openssl.h - Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_openssl.h

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop

Patch Set: Fixed copiler issue in SSLClientSocketNSS Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_openssl.h

diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h

index 37be6bb3e30bef75e8d4fd10a252c6828f9df390..3c84394f2b39b4a654accafe671c27104a561757 100644

--- a/net/socket/ssl_client_socket_openssl.h

+++ b/net/socket/ssl_client_socket_openssl.h

@@ -57,6 +57,7 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {

}

// SSLClientSocket implementation.

+ virtual std::string GetSessionCacheKey() const OVERRIDE;

virtual bool InSessionCache() const OVERRIDE;

virtual void SetHandshakeCompletionCallback(

const base::Closure& callback) OVERRIDE;

@@ -110,8 +111,6 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {

void DoReadCallback(int result);

void DoWriteCallback(int result);

- // Compute a unique key string for the SSL session cache.

- std::string GetSessionCacheKey() const;

void OnHandshakeCompletion();

bool DoTransportIO();

« no previous file with comments | « net/socket/ssl_client_socket_nss.cc ('k') | net/socket/ssl_client_socket_openssl.cc » ('j') | no next file with comments »