Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: net/socket/socket_test_util.cc

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop
Patch Set: Fixed copiler issue in SSLClientSocketNSS Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/socket_test_util.h ('k') | net/socket/ssl_client_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.cc
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index 3498c13428d26ee04ff61c04387ecf3b5a946eec..b847a2994d7a601f64578e5434f9395bd932b409 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -764,6 +764,11 @@ const BoundNetLog& MockClientSocket::NetLog() const {
return net_log_;
}
+std::string MockClientSocket::GetSessionCacheKey() const {
+ NOTIMPLEMENTED();
+ return std::string();
+}
+
bool MockClientSocket::InSessionCache() const {
NOTIMPLEMENTED();
return false;
@@ -1322,6 +1327,7 @@ MockSSLClientSocket::MockSSLClientSocket(
// tests.
transport_socket->socket()->NetLog()),
transport_(transport_socket.Pass()),
+ host_port_pair_(host_port_pair),
data_(data),
is_npn_state_set_(false),
new_npn_value_(false),
@@ -1389,6 +1395,12 @@ bool MockSSLClientSocket::GetSSLInfo(SSLInfo* ssl_info) {
return true;
}
+std::string MockSSLClientSocket::GetSessionCacheKey() const {
+ // For the purposes of these tests, |host_and_port| will serve as the
+ // cache key.
+ return host_port_pair_.ToString();
+}
+
bool MockSSLClientSocket::InSessionCache() const {
return data_->is_in_session_cache;
}
« no previous file with comments | « net/socket/socket_test_util.h ('k') | net/socket/ssl_client_socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698