Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop
Patch Set: Added documentation and removed the cache_key argument from ConnectionCompleteCallback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 92af627b7f871e3edc19ae201c9da6919fc0a5ee..c3e35310abb664ecb4d38dcbe3d9047d9c28ed88 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -2834,6 +2834,11 @@ bool SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) {
return true;
}
+std::string SSLClientSocketNSS::GetSessionCacheKey() const {
wtc 2014/08/14 00:46:45 IMPORTANT: add a declaration of this method (with
mshelley 2014/08/14 20:01:36 Done.
+ NOTIMPLEMENTED();
+ return std::string();
wtc 2014/08/14 00:46:45 Note: you can actually implement this function --
mshelley 2014/08/14 20:01:36 OK -- does the session cache used by NSS use the s
+}
+
bool SSLClientSocketNSS::InSessionCache() const {
// For now, always return true so that SSLConnectJobs are never held back.
return true;

Powered by Google App Engine
This is Rietveld 408576698