Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: net/socket/ssl_client_socket.h

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop
Patch Set: Added documentation and removed the cache_key argument from ConnectionCompleteCallback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket.h
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index 74423c1a626194545e5c672d466f485f819f1a62..9e0d6fb095b7292f45fb12580f3d393895dcc687 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -83,15 +83,8 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
virtual bool WasNpnNegotiated() const OVERRIDE;
virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
- // Formats a unique key for the SSL session cache. This method
- // is necessary so that all classes create cache keys in a consistent
- // manner.
- // TODO(mshelley) This method will be deleted in an upcoming CL when
- // it will no longer be necessary to generate a cache key outside of
- // an SSLClientSocket.
- static std::string CreateSessionCacheKey(
- const HostPortPair& host_and_port,
- const std::string& ssl_session_cache_shard);
+ // Compute a unique key string for the SSL session cache.
wtc 2014/08/14 00:46:45 Nit: Compute => Computes
mshelley 2014/08/14 20:01:36 Done.
+ virtual std::string GetSessionCacheKey() const = 0;
// Returns true if there is a cache entry in the SSL session cache
// for the cache key of the SSL socket.

Powered by Google App Engine
This is Rietveld 408576698