net/http/http_proxy_client_socket_pool.cc - Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_proxy_client_socket_pool.cc

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop

Patch Set: Rebase, fixed issue where messenger field wasn't set to NULL after deletion Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_proxy_client_socket_pool.cc

diff --git a/net/http/http_proxy_client_socket_pool.cc b/net/http/http_proxy_client_socket_pool.cc

index 829a5e78314968bca7b6acce7b9f6fd3c7215482..8b8c25ff6f2bd9ffbdf6f62b77a937fb0ba6d741 100644

--- a/net/http/http_proxy_client_socket_pool.cc

+++ b/net/http/http_proxy_client_socket_pool.cc

@@ -391,12 +391,11 @@ HttpProxyConnectJobFactory::HttpProxyConnectJobFactory(

base::TimeDelta::FromSeconds(kHttpProxyConnectJobTimeoutInSeconds);

}

scoped_ptr<ConnectJob>

HttpProxyClientSocketPool::HttpProxyConnectJobFactory::NewConnectJob(

const std::string& group_name,

const PoolBase::Request& request,

- ConnectJob::Delegate* delegate) const {

+ ConnectJob::Delegate* delegate) {

return scoped_ptr<ConnectJob>(new HttpProxyConnectJob(group_name,

request.priority(),

request.params(),

« no previous file with comments | « net/http/http_proxy_client_socket_pool.h ('k') | net/socket/client_socket_pool_base.h » ('j') | net/socket/client_socket_pool_base.h » ('J')