Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: net/socket/transport_client_socket_pool.h

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop
Patch Set: Rebase, fixed issue where messenger field wasn't set to NULL after deletion Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_ 5 #ifndef NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_
6 #define NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_ 6 #define NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 host_resolver_(host_resolver), 258 host_resolver_(host_resolver),
259 net_log_(net_log) {} 259 net_log_(net_log) {}
260 260
261 virtual ~TransportConnectJobFactory() {} 261 virtual ~TransportConnectJobFactory() {}
262 262
263 // ClientSocketPoolBase::ConnectJobFactory methods. 263 // ClientSocketPoolBase::ConnectJobFactory methods.
264 264
265 virtual scoped_ptr<ConnectJob> NewConnectJob( 265 virtual scoped_ptr<ConnectJob> NewConnectJob(
266 const std::string& group_name, 266 const std::string& group_name,
267 const PoolBase::Request& request, 267 const PoolBase::Request& request,
268 ConnectJob::Delegate* delegate) const OVERRIDE; 268 ConnectJob::Delegate* delegate) OVERRIDE;
269 269
270 virtual base::TimeDelta ConnectionTimeout() const OVERRIDE; 270 virtual base::TimeDelta ConnectionTimeout() const OVERRIDE;
271 271
272 private: 272 private:
273 ClientSocketFactory* const client_socket_factory_; 273 ClientSocketFactory* const client_socket_factory_;
274 HostResolver* const host_resolver_; 274 HostResolver* const host_resolver_;
275 NetLog* net_log_; 275 NetLog* net_log_;
276 276
277 DISALLOW_COPY_AND_ASSIGN(TransportConnectJobFactory); 277 DISALLOW_COPY_AND_ASSIGN(TransportConnectJobFactory);
278 }; 278 };
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 break; 333 break;
334 } 334 }
335 } while (rv != ERR_IO_PENDING && next_state_ != STATE_NONE); 335 } while (rv != ERR_IO_PENDING && next_state_ != STATE_NONE);
336 336
337 return rv; 337 return rv;
338 } 338 }
339 339
340 } // namespace net 340 } // namespace net
341 341
342 #endif // NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_ 342 #endif // NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698