Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: net/socket/socks_client_socket_pool.h

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop
Patch Set: Rebase, fixed issue where messenger field wasn't set to NULL after deletion Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_ 5 #ifndef NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_
6 #define NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_ 6 #define NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 : transport_pool_(transport_pool), 182 : transport_pool_(transport_pool),
183 host_resolver_(host_resolver), 183 host_resolver_(host_resolver),
184 net_log_(net_log) {} 184 net_log_(net_log) {}
185 185
186 virtual ~SOCKSConnectJobFactory() {} 186 virtual ~SOCKSConnectJobFactory() {}
187 187
188 // ClientSocketPoolBase::ConnectJobFactory methods. 188 // ClientSocketPoolBase::ConnectJobFactory methods.
189 virtual scoped_ptr<ConnectJob> NewConnectJob( 189 virtual scoped_ptr<ConnectJob> NewConnectJob(
190 const std::string& group_name, 190 const std::string& group_name,
191 const PoolBase::Request& request, 191 const PoolBase::Request& request,
192 ConnectJob::Delegate* delegate) const OVERRIDE; 192 ConnectJob::Delegate* delegate) OVERRIDE;
193 193
194 virtual base::TimeDelta ConnectionTimeout() const OVERRIDE; 194 virtual base::TimeDelta ConnectionTimeout() const OVERRIDE;
195 195
196 private: 196 private:
197 TransportClientSocketPool* const transport_pool_; 197 TransportClientSocketPool* const transport_pool_;
198 HostResolver* const host_resolver_; 198 HostResolver* const host_resolver_;
199 NetLog* net_log_; 199 NetLog* net_log_;
200 200
201 DISALLOW_COPY_AND_ASSIGN(SOCKSConnectJobFactory); 201 DISALLOW_COPY_AND_ASSIGN(SOCKSConnectJobFactory);
202 }; 202 };
203 203
204 TransportClientSocketPool* const transport_pool_; 204 TransportClientSocketPool* const transport_pool_;
205 PoolBase base_; 205 PoolBase base_;
206 206
207 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketPool); 207 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketPool);
208 }; 208 };
209 209
210 } // namespace net 210 } // namespace net
211 211
212 #endif // NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_ 212 #endif // NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698