Add notification of data reduction proxy field trial

Add notification of data reduction proxy field trial

Adds an InfoBar and a description in Settings to inform users
that they are part of a data reduction proxy field trial. This
trial only includes users that enabled the data reduction proxy.

BUG=383988
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284254

[bengr, 2014-07-10 18:16:25]

tedchoc: chrome/android/, chrome/browser/android/, chrome/browser/ui/android

marq: chrome/browser/net/spdyproxy

dfalcantara: overall

[marq (ping after 24h), 2014-07-11 16:16:12]

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc:40: 
Spurious newline.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:17: class
DataReductionProxyInfoBarDelegate : public ConfirmInfoBarDelegate {
Needs a class comment, especially in this case where we want to be clear that
iOS doesn't care about this.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:19: static
void Create(content::WebContents* web_contents);
Needs a method comment.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:21: 
Spurious newline.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:36: 
Extra line.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h:53:
jboolean IsInAltFieldTrial(JNIEnv* env, jobject obj);
This should be named to match the superclass method
(IsIncludedInAlternativeFieldTrial), per the comment above.

[bengr, 2014-07-11 21:39:42]

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc:40: 
On 2014/07/11 16:16:11, marq_ wrote:
> Spurious newline.

Done.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:17: class
DataReductionProxyInfoBarDelegate : public ConfirmInfoBarDelegate {
On 2014/07/11 16:16:11, marq_ wrote:
> Needs a class comment, especially in this case where we want to be clear that
> iOS doesn't care about this.

Done.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:19: static
void Create(content::WebContents* web_contents);
On 2014/07/11 16:16:11, marq_ wrote:
> Needs a method comment.

Done.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:21: 
On 2014/07/11 16:16:11, marq_ wrote:
> Spurious newline.

Done.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:36: 
On 2014/07/11 16:16:11, marq_ wrote:
> Extra line.

Done.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h:53:
jboolean IsInAltFieldTrial(JNIEnv* env, jobject obj);
On 2014/07/11 16:16:11, marq_ wrote:
> This should be named to match the superclass method
> (IsIncludedInAlternativeFieldTrial), per the comment above.

Actually, I can't use the word "Alternative" because the jni parser sees this as
"Alter" and "native" and strips the native. Also, if I rename the method in the
base class, I'll have to change a bunch of locations. Let's keep it as is for
this CL and we'll unify the names if the field trial proves useful to have for
more than a milestone or two.

[gone, 2014-07-11 21:50:15]

Cursory comments while you're taking a look.

https://codereview.chromium.org/384853002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:18:
static String sSettingsClassName;
private static where appropriate

also make sure to run findbugs

https://codereview.chromium.org/384853002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:23:
public static void launch(WebContents webContents,
Little odd that we're setting the static variables each time the InfoBar gets
launched, but I guess the infobar only gets shown once,anyway?

https://codereview.chromium.org/384853002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:35:
public DataReductionProxyInfoBar(long nativeInfoBar, int iconDrawableId) {
should this constructor be public?

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/ui/androi...
File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h (right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/ui/androi...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h:7: 
random newlines

[bengr, 2014-07-11 23:02:25]

https://codereview.chromium.org/384853002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:18:
static String sSettingsClassName;
On 2014/07/11 21:50:15, dfalcantara wrote:
> private static where appropriate
> 
> also make sure to run findbugs

Done.

https://codereview.chromium.org/384853002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:23:
public static void launch(WebContents webContents,
On 2014/07/11 21:50:15, dfalcantara wrote:
> Little odd that we're setting the static variables each time the InfoBar gets
> launched, but I guess the infobar only gets shown once,anyway?

Right. I agree it's a little odd. The alternative is to plumb these values to
native and back.

https://codereview.chromium.org/384853002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:35:
public DataReductionProxyInfoBar(long nativeInfoBar, int iconDrawableId) {
On 2014/07/11 21:50:15, dfalcantara wrote:
> should this constructor be public?

Done.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/ui/androi...
File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h (right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/ui/androi...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h:7: 
On 2014/07/11 21:50:15, dfalcantara wrote:
> random newlines

Done.

[marq (ping after 24h), 2014-07-11 23:53:46]

LGTM with comment nit.

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h
(right):

https://codereview.chromium.org/384853002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h:53:
jboolean IsInAltFieldTrial(JNIEnv* env, jobject obj);
On 2014/07/11 21:39:42, bengr1 wrote:
> On 2014/07/11 16:16:11, marq_ wrote:
> > This should be named to match the superclass method
> > (IsIncludedInAlternativeFieldTrial), per the comment above.
> 
> Actually, I can't use the word "Alternative" because the jni parser sees this
as
> "Alter" and "native" and strips the native.

Awesome feature. I'm sure that never causes problems.

> Also, if I rename the method in the
> base class, I'll have to change a bunch of locations. Let's keep it as is for
> this CL and we'll unify the names if the field trial proves useful to have for
> more than a milestone or two.

https://codereview.chromium.org/384853002/diff/80001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h
(right):

https://codereview.chromium.org/384853002/diff/80001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:19: // and
a link, and is used only be an Android field trial.
Proofread the last sentence.

[gone, 2014-07-14 16:43:00]

lgtm on my end

[bengr, 2014-07-15 16:03:54]

https://codereview.chromium.org/384853002/diff/80001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h
(right):

https://codereview.chromium.org/384853002/diff/80001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:19: // and
a link, and is used only be an Android field trial.
On 2014/07/11 23:53:46, marq_ wrote:
> Proofread the last sentence.

Done.

[bengr, 2014-07-15 21:34:54]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-07-15 21:39:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/384853002/100001

[bengr, 2014-07-15 22:48:10]

Since Ted is out...

nyquist: chrome/browser/android/
aruslan: chrome/android/, chrome/browser/ui/android

[nyquist, 2014-07-15 22:49:31]

chrome/browser/android lgtm

[aruslan, 2014-07-15 23:14:29]

chrome/android/, chrome/browser/ui/android lgtm.

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java
(right):

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:23:
public static void launch(WebContents webContents,
nit: javadoc + why it is setting static variables.

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
(right):

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java:15:
public static void launch(WebContents webContents) {
nit: javadoc.  should it be accessible from outside the package?

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java:43:

nit: stray empty line

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc (right):

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:15: void
Launch(JNIEnv* env, jclass clazz, jobject jweb_contents) {
nit: add some comment like // JNI for DataReductionProxyInfoBarDelegate

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:29:
scoped_ptr<infobars::InfoBar> DataReductionProxyInfoBarDelegate::CreateInfoBar(
nit: This file combines implementations from different classes, so some comments
like // DataReductionProxyInfoBarDelegate: might be helpful.

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:29:
scoped_ptr<infobars::InfoBar> DataReductionProxyInfoBarDelegate::CreateInfoBar(
nit: It would be great if you could order the methods as in corresponding header
files.  This way you would have only three sections: implementations for
DataReductionProxyInfoBar, implementations for DataReductionProxyInfoBarDelegate
and JNI-related stuff.

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h (right):

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h:29:
java_data_reduction_proxy_delegate_;
nit: +4?

[bengr, 2014-07-16 00:43:26]

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java
(right):

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:23:
public static void launch(WebContents webContents,
On 2014/07/15 23:14:28, aruslan wrote:
> nit: javadoc + why it is setting static variables.

Done. The alternative was to pass this info to native and have native send it
back. This is more efficient.

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
(right):

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java:15:
public static void launch(WebContents webContents) {
On 2014/07/15 23:14:28, aruslan wrote:
> nit: javadoc.  should it be accessible from outside the package?

Done and done.

https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java:43:

On 2014/07/15 23:14:28, aruslan wrote:
> nit: stray empty line

Done.

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc (right):

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:15: void
Launch(JNIEnv* env, jclass clazz, jobject jweb_contents) {
On 2014/07/15 23:14:28, aruslan wrote:
> nit: add some comment like // JNI for DataReductionProxyInfoBarDelegate

Done.

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:29:
scoped_ptr<infobars::InfoBar> DataReductionProxyInfoBarDelegate::CreateInfoBar(
On 2014/07/15 23:14:28, aruslan wrote:
> nit: This file combines implementations from different classes, so some
comments
> like // DataReductionProxyInfoBarDelegate: might be helpful.

Done.

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:29:
scoped_ptr<infobars::InfoBar> DataReductionProxyInfoBarDelegate::CreateInfoBar(
On 2014/07/15 23:14:28, aruslan wrote:
> nit: It would be great if you could order the methods as in corresponding
header
> files.  This way you would have only three sections: implementations for
> DataReductionProxyInfoBar, implementations for
DataReductionProxyInfoBarDelegate
> and JNI-related stuff.

Done.

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h (right):

https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h:29:
java_data_reduction_proxy_delegate_;
On 2014/07/15 23:14:29, aruslan wrote:
> nit: +4?

Style is unclear about this. For function declarations the style is not to
indent after a line break. There is no recommendation for variable declarations.
I prefer the way I wrote it.

[aruslan, 2014-07-16 00:52:24]

On 2014/07/16 00:43:26, bengr1 wrote:
>
https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java
> (right):
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:23:
> public static void launch(WebContents webContents,
> On 2014/07/15 23:14:28, aruslan wrote:
> > nit: javadoc + why it is setting static variables.
> 
> Done. The alternative was to pass this info to native and have native send it
> back. This is more efficient.
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
> (right):
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java:15:
> public static void launch(WebContents webContents) {
> On 2014/07/15 23:14:28, aruslan wrote:
> > nit: javadoc.  should it be accessible from outside the package?
> 
> Done and done.
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java:43:
> 
> On 2014/07/15 23:14:28, aruslan wrote:
> > nit: stray empty line
> 
> Done.
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
> File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc
(right):
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
> chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:15: void
> Launch(JNIEnv* env, jclass clazz, jobject jweb_contents) {
> On 2014/07/15 23:14:28, aruslan wrote:
> > nit: add some comment like // JNI for DataReductionProxyInfoBarDelegate
> 
> Done.
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
> chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:29:
> scoped_ptr<infobars::InfoBar>
DataReductionProxyInfoBarDelegate::CreateInfoBar(
> On 2014/07/15 23:14:28, aruslan wrote:
> > nit: This file combines implementations from different classes, so some
> comments
> > like // DataReductionProxyInfoBarDelegate: might be helpful.
> 
> Done.
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
> chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc:29:
> scoped_ptr<infobars::InfoBar>
DataReductionProxyInfoBarDelegate::CreateInfoBar(
> On 2014/07/15 23:14:28, aruslan wrote:
> > nit: It would be great if you could order the methods as in corresponding
> header
> > files.  This way you would have only three sections: implementations for
> > DataReductionProxyInfoBar, implementations for
> DataReductionProxyInfoBarDelegate
> > and JNI-related stuff.
> 
> Done.
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
> File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h
(right):
> 
>
https://codereview.chromium.org/384853002/diff/100001/chrome/browser/ui/andro...
> chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h:29:
> java_data_reduction_proxy_delegate_;
> On 2014/07/15 23:14:29, aruslan wrote:
> > nit: +4?
> 
> Style is unclear about this. For function declarations the style is not to
> indent after a line break. There is no recommendation for variable
declarations.
> I prefer the way I wrote it.

Thanks for cleaning this up, Ben!

[bengr, 2014-07-16 01:03:18]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-07-16 01:08:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/384853002/120001

[commit-bot: I haz the power, 2014-07-16 09:16:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-07-16 09:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 09:31:02]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[bengr, 2014-07-17 16:16:54]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-07-17 16:17:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/384853002/160001

[commit-bot: I haz the power, 2014-07-17 16:57:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29781)

[commit-bot: I haz the power, 2014-07-17 16:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 16:59:08]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29810)

[bengr, 2014-07-18 19:05:26]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-07-18 19:08:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/384853002/180001

[commit-bot: I haz the power, 2014-07-18 21:03:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-18 23:50:50]

Change committed as 284254