Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/webstore_bindings.cc
diff --git a/chrome/renderer/extensions/webstore_bindings.cc b/chrome/renderer/extensions/webstore_bindings.cc
index 4ceee5e8abf46ea0acb5b80cdea335d453e91317..2c2f06a2de7ebce71f4ead251523b63f8ebfc780 100644
--- a/chrome/renderer/extensions/webstore_bindings.cc
+++ b/chrome/renderer/extensions/webstore_bindings.cc
@@ -202,14 +202,17 @@ bool WebstoreBindings::OnMessageReceived(const IPC::Message& message) {
void WebstoreBindings::OnInlineWebstoreInstallResponse(
int install_id,
bool success,
- const std::string& error) {
+ const std::string& error,
+ webstore_install::Result result) {
v8::Isolate* isolate = context()->isolate();
v8::HandleScope handle_scope(isolate);
v8::Context::Scope context_scope(context()->v8_context());
v8::Handle<v8::Value> argv[] = {
v8::Integer::New(isolate, install_id),
v8::Boolean::New(isolate, success),
- v8::String::NewFromUtf8(isolate, error.c_str())
+ v8::String::NewFromUtf8(isolate, error.c_str()),
+ v8::String::NewFromUtf8(
+ isolate, api::webstore::kInstallResultCodes[static_cast<int>(result)])
};
context()->module_system()->CallModuleMethod(
"webstore", "onInstallResponse", arraysize(argv), argv);

Powered by Google App Engine
This is Rietveld 408576698