chrome/test/data/extensions/api_test/webstore_inline_install/install_unpack_failure.html - Issue 384823002: Introduce a stable set of errors for inline install

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webstore_inline_install/install_unpack_failure.html

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/webstore.json ('K') | « chrome/test/data/extensions/api_test/webstore_inline_install/install_prohibited.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webstore_inline_install/install_unpack_failure.html

diff --git a/chrome/test/data/extensions/api_test/webstore_inline_install/install_unpack_failure.html b/chrome/test/data/extensions/api_test/webstore_inline_install/install_unpack_failure.html

index d638582da1aed79ead8f540600d85fcbf6823ef5..16826f8188cbdf9b66592628c1659f0c20c7226c 100644

--- a/chrome/test/data/extensions/api_test/webstore_inline_install/install_unpack_failure.html

+++ b/chrome/test/data/extensions/api_test/webstore_inline_install/install_unpack_failure.html

@@ -18,8 +18,9 @@

console.log('Unexpected install success');

window.domAutomationController.send(false);

- function(error) {

- if (error.indexOf('Package is invalid') != -1) {

+ function(error, errorCode) {

+ if (error.indexOf('Package is invalid') != -1 &&

+ errorCode == 'otherError') {

window.domAutomationController.send(true);

} else {

console.log('Unexpected install error: ' + error);

« chrome/common/extensions/api/webstore.json ('K') | « chrome/test/data/extensions/api_test/webstore_inline_install/install_prohibited.html ('k') | no next file » | no next file with comments »