chrome/browser/ui/app_list/search/webstore/webstore_result.cc - Issue 384823002: Introduce a stable set of errors for inline install

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/webstore/webstore_result.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/search/webstore/webstore_result.cc

diff --git a/chrome/browser/ui/app_list/search/webstore/webstore_result.cc b/chrome/browser/ui/app_list/search/webstore/webstore_result.cc

index 3e265593b41ea44d65937af5887ed4b783f6e0c1..6e21fd7a8b1aafd6b8912e9b888ab321045c4d05 100644

--- a/chrome/browser/ui/app_list/search/webstore/webstore_result.cc

+++ b/chrome/browser/ui/app_list/search/webstore/webstore_result.cc

@@ -215,7 +215,10 @@ void WebstoreResult::StartInstall(bool launch_ephemeral_app) {

installer->BeginInstall();

}

-void WebstoreResult::InstallCallback(bool success, const std::string& error) {

+void WebstoreResult::InstallCallback(

+ bool success,

+ const std::string& error,

+ extensions::webstore_install::Result result) {

if (!success) {

LOG(ERROR) << "Failed to install app, error=" << error;

SetIsInstalling(false);