Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/apps/ephemeral_app_launcher.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/ephemeral_app_launcher.cc
diff --git a/chrome/browser/apps/ephemeral_app_launcher.cc b/chrome/browser/apps/ephemeral_app_launcher.cc
index 37910c8a4421076c43cdc3e26e4cebe46229e2a2..51b1908b91a73b2fd5491bff6c7948decaa1fcae 100644
--- a/chrome/browser/apps/ephemeral_app_launcher.cc
+++ b/chrome/browser/apps/ephemeral_app_launcher.cc
@@ -132,7 +132,7 @@ void EphemeralAppLauncher::Start() {
ExtensionRegistry::Get(profile())
->GetExtensionById(id(), ExtensionRegistry::EVERYTHING);
if (extension) {
- webstore_install::Result result = webstore_install::UNKNOWN_ERROR;
+ webstore_install::Result result = webstore_install::OTHER_ERROR;
std::string error;
if (!CanLaunchInstalledApp(extension, &result, &error)) {
InvokeCallback(result, error);
@@ -225,7 +225,7 @@ bool EphemeralAppLauncher::CanLaunchInstalledApp(
void EphemeralAppLauncher::EnableInstalledApp(const Extension* extension) {
// Check whether an install is already in progress.
- webstore_install::Result result = webstore_install::UNKNOWN_ERROR;
+ webstore_install::Result result = webstore_install::OTHER_ERROR;
std::string error;
if (!EnsureUniqueInstall(&result, &error)) {
InvokeCallback(result, error);
@@ -246,7 +246,7 @@ void EphemeralAppLauncher::EnableInstalledApp(const Extension* extension) {
}
void EphemeralAppLauncher::MaybeLaunchApp() {
- webstore_install::Result result = webstore_install::UNKNOWN_ERROR;
+ webstore_install::Result result = webstore_install::OTHER_ERROR;
std::string error;
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
@@ -329,7 +329,7 @@ void EphemeralAppLauncher::CheckEphemeralInstallPermitted() {
void EphemeralAppLauncher::OnInstallChecked(int check_failures) {
if (!CheckRequestorAlive()) {
- AbortLaunch(webstore_install::UNKNOWN_ERROR, std::string());
+ AbortLaunch(webstore_install::OTHER_ERROR, std::string());
return;
}
@@ -410,7 +410,7 @@ void EphemeralAppLauncher::OnManifestParsed() {
return;
}
- webstore_install::Result result = webstore_install::UNKNOWN_ERROR;
+ webstore_install::Result result = webstore_install::OTHER_ERROR;
std::string error;
if (!CheckCommonLaunchCriteria(profile(), extension, &result, &error)) {
AbortLaunch(result, error);
« no previous file with comments | « no previous file | chrome/browser/apps/ephemeral_app_launcher_browsertest.cc » ('j') | chrome/common/extensions/api/webstore.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698