Introduce a stable set of errors for inline install

chrome/common/extensions/api/webstore/webstore_api_constants.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/webstore/webstore_api_constants.h"
 
 namespace extensions {
 namespace api {
 namespace webstore {
 
+// IMPORTANT: Keep this list in sync with both the definition in
+// chrome/common/extensions/api/webstore.json and
+// chrome/common/extensions/webstore_install_result.h!

[not at google - send to devlin, 2014/07/10 20:54:27]

could you add a unit test for chrome/common/extensions/webstore_install_result.h
which sanity checks this? it can
- run from 0 to LAST and dereference this list. ASAN should catch whether it
hasn't been updated.
- assert that LAST is 15 (or whatever it is) with the failure comment being a
reminder to update this list and the one in the JSON file

[Devlin, 2014/07/10 22:11:43]

As discussed offline, a compile assert covers as much, needs less code, and has
the advantage of immediate feedback. :)

+const char* kInstallResultCodes[] = {
+  "success",
+  "otherError",  // This corresponds to UNKNOWN_ERROR, but "other" sounds a lot

[not at google - send to devlin, 2014/07/10 20:54:27]

I actually prefer "unknown" :)

[Devlin, 2014/07/10 21:16:59]

Typically, I do too.  But this is special, because we _do_ know the error - we
even send a string explaining it.  We just don't
a) keep track of it through the installation process or
b) have a mapping from our error messages to error codes.

So it seems silly to say
error: "Extensions cannot be installed for a supervised user"
errorCode: "unknownError"

At least, that's my impression.  If you still prefer unknownError, I can change
it :)

[not at google - send to devlin, 2014/07/10 21:18:38]

ah :) well can you rename the enum then?

[Devlin, 2014/07/10 22:11:43]

Yep. :)

+                 // better.
+  "aborted",
+  "notPermitted",
+  "invalidId",
+  "webstoreRequestError",
+  "invalidWebstoreResponse",
+  "invalidManifest",
+  "iconError",
+  "userCancelled",
+  "blacklisted",
+  "missingDependencies",
+  "requirementViolations",
+  "blockedByPolicy",
+  "launchFeatureDisabled",
+  "launchUnsupportedExtensionType",
+};
+
 // The "downloading" stage begins when the installer starts downloading modules
 // for the extension.
 const char kInstallStageDownloading[] = "downloading";
 
 // The "installing" stage begins once all downloads are complete, and the
 // CrxInstaller begins.
 const char kInstallStageInstalling[] = "installing";
 
 // The method in custom_webstore_bindings.js triggered when we enter a new
 // install stage ("downloading" or "installing").
 const char kOnInstallStageChangedMethodName[] = "onInstallStageChanged";
 
 // The method in custom_webstore_bindings.js triggered when we update
 // download progress.
 const char kOnDownloadProgressMethodName[] = "onDownloadProgress";
 
 }  // namespace webstore
 }  // namespace api
 }  // namespace extensions