Issue 384803003: Revert of Experimental app list: Added a current page indicator to the launcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384803003: Revert of Experimental app list: Added a current page indicator to the launcher. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
kcarattini, calamity, Matt Giuca

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Experimental app list: Added a current page indicator to the launcher. (https://codereview.chromium.org/380613002/) Reason for revert: Caused a static initializer, see http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/67534 Original issue's description: > Experimental app list: Added a current page indicator to the launcher. > > Adds a current page indicator to the launcher when the experimental app launcher is enabled. > > BUG=391642 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282335 TBR=calamity@chromium.org,mgiuca@chromium.org,kcarattini@chromium.org NOTREECHECKS=true NOTRY=true BUG=391642 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282378

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -114 lines)			Patch
M	ui/app_list/app_list_constants.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/app_list/app_list_constants.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/app_list/views/app_list_background.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	ui/app_list/views/app_list_main_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/app_list/views/contents_switcher_view.h	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	ui/app_list/views/contents_switcher_view.cc	View	3 chunks	+2 lines, -76 lines	0 comments	Download
M	ui/app_list/views/contents_view.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/app_list/views/contents_view.cc	View	3 chunks	+1 line, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Nico

Created Revert of Experimental app list: Added a current page indicator to the launcher.

6 years, 5 months ago (2014-07-10 18:01:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/384803003/1

6 years, 5 months ago (2014-07-10 18:03:38 UTC) #2

Message was sent while issue was closed.

Change committed as 282378