Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 384793003: PPAPI: Remove content/renderer/pepper/common.h (Closed)

Created:
6 years, 5 months ago by dmichael (off chromium)
Modified:
6 years, 5 months ago
Reviewers:
teravest
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

PPAPI: Remove content/renderer/pepper/common.h This only added conversion functions to/from PP_Bool. We have those in pp_bool.h, so we don't need it. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -43 lines) Patch
M content/renderer/pepper/audio_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/pepper/common.h View 1 chunk +0 lines, -19 lines 0 comments Download
M content/renderer/pepper/event_conversion.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/pepper/ppb_audio_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/pepper/ppb_broker_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/ppb_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/ppb_scrollbar_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/ppb_var_deprecated_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_video_decoder_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/resource_creation_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/pepper/url_request_info_util.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dmichael (off chromium)
6 years, 5 months ago (2014-07-10 17:25:32 UTC) #1
teravest
lgtm
6 years, 5 months ago (2014-07-10 17:28:51 UTC) #2
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 5 months ago (2014-07-10 17:53:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/384793003/1
6 years, 5 months ago (2014-07-10 17:55:38 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 19:35:08 UTC) #5
Message was sent while issue was closed.
Change committed as 282398

Powered by Google App Engine
This is Rietveld 408576698