Chromium Code Reviews| Index: Source/bindings/scripts/v8_attributes.py |
| diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py |
| index cfbdf60360e1eaa9830dbf960f4c298473799378..f49bcc53f8668d1092b6d336c8c82e6a3b6e4f71 100644 |
| --- a/Source/bindings/scripts/v8_attributes.py |
| +++ b/Source/bindings/scripts/v8_attributes.py |
| @@ -114,7 +114,7 @@ def attribute_context(interface, attribute): |
| 'InitializedByEventConstructor' in extended_attributes, |
| 'is_keep_alive_for_gc': is_keep_alive_for_gc(interface, attribute), |
| 'is_nullable': idl_type.is_nullable, |
| - 'is_nullable_simple': idl_type.is_nullable_simple, |
| + 'is_explicit_nullable': idl_type.is_explicit_nullable, |
|
haraken
2014/07/10 15:48:16
alphabetical order
Jens Widell
2014/07/10 15:53:18
Argh! We should implement a presubmit check for th
|
| 'is_partial_interface_member': |
| 'PartialInterfaceImplementedAs' in extended_attributes, |
| 'is_per_world_bindings': 'PerWorldBindings' in extended_attributes, |
| @@ -183,7 +183,7 @@ def getter_context(interface, attribute, context): |
| # EventHandler has special handling |
| if base_idl_type != 'EventHandler': |
| release = idl_type.release |
| - elif ((idl_type.is_nullable and not context['is_nullable_simple']) or |
| + elif (idl_type.is_explicit_nullable or |
| base_idl_type == 'EventHandler' or |
| 'CachedAttribute' in extended_attributes or |
| 'LogPreviousValue' in extended_attributes or |
| @@ -228,7 +228,7 @@ def getter_expression(interface, attribute, context): |
| if ('PartialInterfaceImplementedAs' in attribute.extended_attributes and |
| not attribute.is_static): |
| arguments.append('*impl') |
| - if attribute.idl_type.is_nullable and not context['is_nullable_simple']: |
| + if attribute.idl_type.is_explicit_nullable: |
| arguments.append('isNull') |
| if context['is_getter_raises_exception']: |
| arguments.append('exceptionState') |