Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 384753004: Cleanup SkPicture* classes a bit (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup SkPicture* classes a bit This is an attempt to reduce the number of friends the various SkPicture* classes have. Probably the only controversial part is making getBitmap, getPath, getPicture and getPaint public on SkPictureData (and adding a new initIterator entry point). Committed: https://skia.googlesource.com/skia/+/6142609b22814283210f79d698182b651a93136c

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -50 lines) Patch
M include/core/SkPicture.h View 1 chunk +5 lines, -8 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M src/core/SkPictureData.h View 1 5 chunks +13 lines, -10 lines 0 comments Download
M src/core/SkPictureData.cpp View 8 chunks +22 lines, -13 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-10 15:56:42 UTC) #1
reed1
api very-lgtm
6 years, 5 months ago (2014-07-10 15:58:04 UTC) #2
mtklein
lgtm Adding these public accessors to SkPictureData seems totally reasonable to me.
6 years, 5 months ago (2014-07-10 15:59:51 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-10 16:22:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/384753004/20001
6 years, 5 months ago (2014-07-10 16:22:59 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 16:35:17 UTC) #6
Message was sent while issue was closed.
Change committed as 6142609b22814283210f79d698182b651a93136c

Powered by Google App Engine
This is Rietveld 408576698