Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: runtime/vm/intermediate_language.h

Issue 384703002: Revert r38116 because of crashes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 38117)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -724,7 +724,6 @@
M(DoubleToFloat) \
M(FloatToDouble) \
M(CheckClass) \
- M(CheckClassId) \
M(CheckSmi) \
M(Constant) \
M(UnboxedConstant) \
@@ -1105,7 +1104,6 @@
friend class MathUnaryInstr;
friend class MathMinMaxInstr;
friend class CheckClassInstr;
- friend class CheckClassIdInstr;
friend class GuardFieldInstr;
friend class CheckSmiInstr;
friend class CheckArrayBoundInstr;
@@ -7895,18 +7893,12 @@
const ICData& unary_checks() const { return unary_checks_; }
- const GrowableArray<intptr_t>& cids() const { return cids_; }
-
virtual Instruction* Canonicalize(FlowGraph* flow_graph);
virtual void PrintOperandsTo(BufferFormatter* f) const;
bool IsNullCheck() const;
- bool IsDenseSwitch() const;
- intptr_t ComputeCidMask() const;
- static bool IsDenseMask(intptr_t mask);
-
virtual bool AllowsCSE() const { return true; }
virtual EffectSet Effects() const { return EffectSet::None(); }
virtual EffectSet Dependencies() const;
@@ -7918,7 +7910,6 @@
private:
const ICData& unary_checks_;
- GrowableArray<intptr_t> cids_; // Sorted, lowest first.
bool licm_hoisted_;
const intptr_t token_pos_;
@@ -7960,36 +7951,6 @@
};
-class CheckClassIdInstr : public TemplateInstruction<2> {
- public:
- CheckClassIdInstr(Value* left, Value* right, intptr_t deopt_id) {
- SetInputAt(0, left);
- SetInputAt(1, right);
- // Override generated deopt-id.
- deopt_id_ = deopt_id;
- }
-
- Value* left() const { return inputs_[0]; }
- Value* right() const { return inputs_[1]; }
-
- DECLARE_INSTRUCTION(CheckClassId)
-
- virtual intptr_t ArgumentCount() const { return 0; }
-
- virtual bool CanDeoptimize() const { return true; }
-
- virtual bool AllowsCSE() const { return false; }
- virtual EffectSet Effects() const { return EffectSet::None(); }
- virtual EffectSet Dependencies() const { return EffectSet::None(); }
- virtual bool AttributesEqual(Instruction* other) const { return true; }
-
- virtual bool MayThrow() const { return false; }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(CheckClassIdInstr);
-};
-
-
class CheckArrayBoundInstr : public TemplateInstruction<2> {
public:
CheckArrayBoundInstr(Value* length, Value* index, intptr_t deopt_id) {
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698