chrome/browser/extensions/api/page_capture/page_capture_api.cc - Issue 384653002: Improve robustness of pageCapture.saveAsMHTML custom binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_api.cc

Issue 384653002: Improve robustness of pageCapture.saveAsMHTML custom binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address rdevlin's review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/page_capture/page_capture_api.cc

diff --git a/chrome/browser/extensions/api/page_capture/page_capture_api.cc b/chrome/browser/extensions/api/page_capture/page_capture_api.cc

index 046c5be187fa63d78973d6bce7aa3793404fded4..b342c2488ce8a314dac7ac7e9fc02e93d6f3a3ad 100644

--- a/chrome/browser/extensions/api/page_capture/page_capture_api.cc

+++ b/chrome/browser/extensions/api/page_capture/page_capture_api.cc

@@ -32,7 +32,7 @@ namespace {

const char kFileTooBigError[] = "The MHTML file generated is too big.";

const char kMHTMLGenerationFailedError[] = "Failed to generate MHTML.";

const char kTemporaryFileError[] = "Failed to create a temporary file.";

-const char kTabClosedError[] = "Cannot find the tab for thie request.";

+const char kTabClosedError[] = "Cannot find the tab for this request.";

} // namespace

« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/page_capture_custom_bindings.js » ('j') | no next file with comments »