Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: chrome/renderer/resources/extensions/page_capture_custom_bindings.js

Issue 384653002: Improve robustness of pageCapture.saveAsMHTML custom binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address rdevlin's review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/api/page_capture/page_capture_api.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the pageCapture API. 5 // Custom binding for the pageCapture API.
6 6
7 var binding = require('binding').Binding.create('pageCapture'); 7 var binding = require('binding').Binding.create('pageCapture');
8 8
9 var handleUncaughtException = require('uncaught_exception_handler').handle;
9 var pageCaptureNatives = requireNative('page_capture'); 10 var pageCaptureNatives = requireNative('page_capture');
10 var CreateBlob = pageCaptureNatives.CreateBlob; 11 var CreateBlob = pageCaptureNatives.CreateBlob;
11 var SendResponseAck = pageCaptureNatives.SendResponseAck; 12 var SendResponseAck = pageCaptureNatives.SendResponseAck;
12 13
13 binding.registerCustomHook(function(bindingsAPI) { 14 binding.registerCustomHook(function(bindingsAPI) {
14 var apiFunctions = bindingsAPI.apiFunctions; 15 var apiFunctions = bindingsAPI.apiFunctions;
15 16
16 apiFunctions.setCustomCallback('saveAsMHTML', 17 apiFunctions.setCustomCallback('saveAsMHTML',
17 function(name, request, response) { 18 function(name, request, response) {
18 var path = response.mhtmlFilePath; 19 var callback = request.callback;
19 var size = response.mhtmlFileLength; 20 request.callback = null;
21 if (response)
22 response = CreateBlob(response.mhtmlFilePath, response.mhtmlFileLength);
20 23
21 if (request.callback) 24 try {
22 request.callback(CreateBlob(path, size)); 25 callback(response);
23 request.callback = null; 26 } catch (e) {
24 27 var message = "Error in chrome.pageCapture.saveAsMHTML callback: " + e;
25 // Notify the browser. Now that the blob is referenced from JavaScript, 28 if (request.stack)
26 // the browser can drop its reference to it. 29 message += "\n" + request.stack;
27 SendResponseAck(request.id); 30 handleUncaughtException(message, e);
31 } finally {
32 // Notify the browser. Now that the blob is referenced from JavaScript,
33 // the browser can drop its reference to it.
34 SendResponseAck(request.id);
35 }
28 }); 36 });
29 }); 37 });
30 38
31 exports.binding = binding.generate(); 39 exports.binding = binding.generate();
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/page_capture/page_capture_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698