Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3846004: Delete safe_browsing_database tests and test data. (Closed)

Created:
10 years, 2 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Delete safe_browsing_database tests and test data. This test data has been useful in experimenting with the impact of file-format changes in safe_browsing_database. Unfortunately, the tests have been ill-maintained and the test data is pretty old. If someone wishes to run further tests, it would be preferable to build something using current best practices, perhaps using the test server recently added for the safe_browsing_test.cc system. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-98 lines, -231 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 2 chunks +0 lines, -237 lines 0 comments Download
D chrome/test/data/safe_browsing/download_update.py View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/data/safe_browsing/filter/database View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/filter/urls View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/000goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/001goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/002goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/003goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/004goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/005goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/006goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/007goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/008goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/009goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/010goog-malware-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/011goog-malware-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/012goog-malware-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/013goog-malware-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/014goog-malware-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/015goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/016goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/017goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/018goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/019goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/020goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/021goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/022goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/023goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/024goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/025goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/026goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/027goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/028goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/029goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/030goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/031goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/032goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/033goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/034goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/035goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/036goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/037goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/038goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/039goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/040goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/041goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/042goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/043goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/044goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/045goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/046goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/047goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/048goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/049goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/050goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/051goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/initial/052goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/SafeBrowsing View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/postdata View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/safe_browsing/old/response View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/000goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/001goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/002goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/003goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/004goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/005goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/006goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/007goog-malware-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/008goog-malware-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/009goog-malware-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/010goog-malware-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/011goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/012goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/013goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/014goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/015goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/016goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/017goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/018goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/019goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/020goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/021goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/022goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/023goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/024goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/025goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/026goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/027goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/028goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/029goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/030goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/031goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/032goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/033goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/034goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/035goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/036goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/037goog-phish-shavar_s View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/038goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/039goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/040goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/041goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/safe_browsing/old/updates/042goog-phish-shavar_a View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Scott Hess - ex-Googler
10 years, 2 months ago (2010-10-17 16:58:57 UTC) #1
Erik does not do reviews
10 years, 2 months ago (2010-10-19 16:21:59 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698