Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 384523003: Cleanups in ChromotingClient (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov
Modified:
6 years, 5 months ago
Reviewers:
rmsousa, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanups in ChromotingClient 1. Moved creation of ConnectionToHost to ChromotingClient. Previously ConnectionToHost had to be passed in the constructor. 2. Authentication now is created outside of ChromotingClient. This allowed to remove ClientConfig struct (it was used mostly to pass authentication parameters). This will also allow passing a fake authenticator for tests. 3. Removed ClientConfig. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282757

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -322 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 1 chunk +13 lines, -5 lines 0 comments Download
M remoting/client/chromoting_client.h View 5 chunks +18 lines, -14 lines 0 comments Download
M remoting/client/chromoting_client.cc View 5 chunks +24 lines, -40 lines 0 comments Download
D remoting/client/client_config.h View 1 chunk +0 lines, -43 lines 0 comments Download
D remoting/client/client_config.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M remoting/client/client_user_interface.h View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.h View 1 4 chunks +2 lines, -6 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 1 14 chunks +32 lines, -42 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 4 chunks +0 lines, -11 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 2 15 chunks +73 lines, -72 lines 0 comments Download
M remoting/ios/bridge/client_instance.h View 4 chunks +2 lines, -6 lines 0 comments Download
M remoting/ios/bridge/client_instance.cc View 14 chunks +32 lines, -47 lines 0 comments Download
M remoting/protocol/connection_to_host.h View 3 chunks +1 line, -4 lines 0 comments Download
M remoting/protocol/connection_to_host.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Sergey Ulanov
6 years, 5 months ago (2014-07-11 00:50:36 UTC) #1
rmsousa
lgtm
6 years, 5 months ago (2014-07-11 01:17:32 UTC) #2
Sergey Ulanov
+dcaiafa, Dan, FYI, I made some changes in the iOS client. I think it should ...
6 years, 5 months ago (2014-07-11 18:48:57 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-11 18:49:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/384523003/1
6 years, 5 months ago (2014-07-11 18:51:04 UTC) #5
dcaiafa
lgtm I'll try the changes as soon as they land. I'll let you know if ...
6 years, 5 months ago (2014-07-11 19:01:43 UTC) #6
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-11 19:25:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/384523003/20001
6 years, 5 months ago (2014-07-11 19:27:45 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 20:53:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 21:03:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/42493) win8_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/builds/3004)
6 years, 5 months ago (2014-07-11 21:03:21 UTC) #11
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-11 21:27:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/384523003/40001
6 years, 5 months ago (2014-07-11 21:27:49 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 00:46:55 UTC) #14
Message was sent while issue was closed.
Change committed as 282757

Powered by Google App Engine
This is Rietveld 408576698