Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 384503008: Delete third_party/harfbuzz (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove public header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -40865 lines) Patch
M gyp/public_headers.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
include/ports/SkHarfBuzzFont.h View 1 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/harfbuzz/.gitignore View 1 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/harfbuzz/AUTHORS View 1 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/harfbuzz/COPYING View 1 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/harfbuzz/ChangeLog View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/harfbuzz/Makefile.am View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/harfbuzz/NEWS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/harfbuzz/README View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/harfbuzz/README.google View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/harfbuzz/autogen.sh View 1 1 chunk +0 lines, -116 lines 0 comments Download
third_party/harfbuzz/chromium.patch View 1 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/harfbuzz/config.h View 1 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/harfbuzz/configure.ac View 1 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/harfbuzz/contrib/README View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/harfbuzz/contrib/harfbuzz-freetype.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/harfbuzz/contrib/harfbuzz-freetype.c View 1 1 chunk +0 lines, -149 lines 0 comments Download
third_party/harfbuzz/contrib/harfbuzz-unicode.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
third_party/harfbuzz/contrib/harfbuzz-unicode.c View 1 1 chunk +0 lines, -287 lines 0 comments Download
D third_party/harfbuzz/contrib/harfbuzz-unicode-glib.c View 1 1 chunk +0 lines, -169 lines 0 comments Download
D third_party/harfbuzz/contrib/harfbuzz-unicode-tables.c View 1 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/BidiMirroring.txt View 1 1 chunk +0 lines, -588 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/DerivedCombiningClass.txt View 1 1 chunk +0 lines, -1881 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/DerivedGeneralCategory.txt View 1 1 chunk +0 lines, -3072 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/GraphemeBreakProperty.txt View 1 1 chunk +0 lines, -1166 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/README View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/Scripts.txt View 1 1 chunk +0 lines, -1747 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/category-parse.py View 1 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/category-properties.h View 1 1 chunk +0 lines, -2869 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/combining-class-parse.py View 1 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/combining-properties.h View 1 1 chunk +0 lines, -247 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/grapheme-break-parse.py View 1 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/grapheme-break-properties.h View 1 1 chunk +0 lines, -1113 lines 0 comments Download
third_party/harfbuzz/contrib/tables/mirroring-parse.py View 1 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/harfbuzz/contrib/tables/mirroring-properties.h View 1 1 chunk +0 lines, -379 lines 0 comments Download
third_party/harfbuzz/contrib/tables/script-properties.h View 1 1 chunk +0 lines, -297 lines 0 comments Download
third_party/harfbuzz/contrib/tables/scripts-parse.py View 1 1 chunk +0 lines, -75 lines 0 comments Download
third_party/harfbuzz/contrib/tables/unicode_parse_common.py View 1 1 chunk +0 lines, -70 lines 0 comments Download
third_party/harfbuzz/harfbuzz.gyp View 1 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/harfbuzz/src/.gitignore View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/harfbuzz/src/Makefile.am View 1 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz.c View 1 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-arabic.c View 1 1 chunk +0 lines, -1145 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-buffer.h View 1 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-buffer.c View 1 1 chunk +0 lines, -383 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-buffer-private.h View 1 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-dump.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-dump.c View 1 1 chunk +0 lines, -765 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-dump-main.c View 1 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-external.h View 1 1 chunk +0 lines, -157 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-gdef.h View 1 1 chunk +0 lines, -135 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-gdef.c View 1 1 chunk +0 lines, -1159 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-gdef-private.h View 1 1 chunk +0 lines, -124 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-global.h View 1 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-gpos.h View 1 1 chunk +0 lines, -149 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-gpos.c View 1 1 chunk +0 lines, -6055 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-gpos-private.h View 1 1 chunk +0 lines, -712 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-gsub.h View 1 1 chunk +0 lines, -141 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-gsub.c View 1 1 chunk +0 lines, -4329 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-gsub-private.h View 1 1 chunk +0 lines, -476 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-hangul.c View 1 1 chunk +0 lines, -268 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-hebrew.c View 1 1 chunk +0 lines, -189 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-impl.h View 1 1 chunk +0 lines, -131 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-impl.c View 1 1 chunk +0 lines, -84 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-indic.cpp View 1 1 chunk +0 lines, -1873 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-khmer.c View 1 1 chunk +0 lines, -667 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-myanmar.c View 1 1 chunk +0 lines, -542 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-open.h View 1 1 chunk +0 lines, -282 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-open.c View 1 1 chunk +0 lines, -1416 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-open-private.h View 1 1 chunk +0 lines, -102 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-shape.h View 1 1 chunk +0 lines, -199 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-shaper.h View 1 1 chunk +0 lines, -278 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-shaper.cpp View 1 1 chunk +0 lines, -1357 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-shaper-all.cpp View 1 1 chunk +0 lines, -36 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-shaper-private.h View 1 1 chunk +0 lines, -167 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-stream.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-stream.c View 1 1 chunk +0 lines, -114 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-stream-private.h View 1 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/harfbuzz/src/harfbuzz-thai.c View 1 1 chunk +0 lines, -87 lines 0 comments Download
third_party/harfbuzz/src/harfbuzz-tibetan.c View 1 1 chunk +0 lines, -274 lines 0 comments Download
third_party/harfbuzz/tests/Makefile.am View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/harfbuzz/tests/linebreaking/.gitignore View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/harfbuzz/tests/linebreaking/Makefile.am View 1 1 chunk +0 lines, -12 lines 0 comments Download
third_party/harfbuzz/tests/linebreaking/harfbuzz-qt.cpp View 1 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/harfbuzz/tests/linebreaking/main.cpp View 1 1 chunk +0 lines, -230 lines 0 comments Download
third_party/harfbuzz/tests/shaping/.gitignore View 1 1 chunk +0 lines, -2 lines 0 comments Download
third_party/harfbuzz/tests/shaping/Makefile.am View 1 1 chunk +0 lines, -14 lines 0 comments Download
third_party/harfbuzz/tests/shaping/README View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/harfbuzz/tests/shaping/main.cpp View 1 1 chunk +0 lines, -1035 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
6 years, 5 months ago (2014-07-10 14:50:53 UTC) #1
bungeman-skia
lgtm
6 years, 5 months ago (2014-07-10 15:04:31 UTC) #2
reed1
lgtm
6 years, 5 months ago (2014-07-10 15:07:54 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-10 15:08:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/384503008/10001
6 years, 5 months ago (2014-07-10 15:09:16 UTC) #5
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-10 15:30:44 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-10 15:30:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/384503008/10001
6 years, 5 months ago (2014-07-10 15:30:48 UTC) #8
mtklein_C
6 years, 5 months ago (2014-07-10 15:32:49 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 manually as r15840a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698