Issue 384503005: Merge 280230 "Flag myIpAddress requests for chromeos"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384503005: Merge 280230 "Flag myIpAddress requests for chromeos" (Closed)

Created:
6 years, 5 months ago by stevenjb

Modified:
6 years, 5 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

Merge 280230 "Flag myIpAddress requests for chromeos" > Flag myIpAddress requests for chromeos > > This is a follow-up to https://codereview.chromium.org/238433003 > > We need to differentiate between myIpAddress requests and other > localhost requests so that local web servers and tests work correctly. > > BUG=387109 > > Review URL: https://codereview.chromium.org/355953002 TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282215

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -3 lines)			Patch
M	chromeos/network/host_resolver_impl_chromeos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/network/host_resolver_impl_chromeos_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/dns/host_resolver.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	net/dns/host_resolver.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/proxy/proxy_resolver_v8_tracing.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r282215.