Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 384503003: Revert of Add queryForNewLocalDevices to gcdPrivate (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Add queryForNewLocalDevices to gcdPrivate (https://codereview.chromium.org/356613002/) Reason for revert: Test failure in Builder: Win7 Tests (dbg)(6) [ RUN ] GcdPrivateAPITest.SendQuery [4036:2900:0709/150928:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! [956:2412:0709/150928:WARNING:extension_apitest.cc(282)] Workaround for 177163, prematurely returning c:\b\build\slave\win_builder__dbg_\build\src\chrome\browser\extensions\api\gcd_private\gcd_private_apitest.cc(276): error: Actual function call count doesn't match EXPECT_CALL(*test_service_discovery_client_, OnSendTo(std::string(reinterpret_cast\u003Cconst char*>(kQueryPacket), sizeof(kQueryPacket))))... Expected: to be called twice Actual: never called - unsatisfied and active [ FAILED ] GcdPrivateAPITest.SendQuery, where TypeParam = and GetParam() = (5746 ms) http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%286%29 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%286%29/builds/27654 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%286%29/builds/27654/steps/browser_tests/logs/SendQuery Original issue's description: > Add function queryForNewLocalDevices to send query for new local devices, > implement it for mDNS (WiFi devices forthcoming) > > BUG=383167 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -81 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_api.h View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/common/extensions/api/gcd_private.idl View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcd_private/api/send_query.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/gcd_private/api/send_query.js View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
horo
Created Revert of Add queryForNewLocalDevices to gcdPrivate
6 years, 5 months ago (2014-07-10 01:24:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/384503003/1
6 years, 5 months ago (2014-07-10 01:27:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 01:27:31 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 01:27:32 UTC) #4
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698