Issue 384443003: Add scalar lowering for sqrt intrinsic.

Issue 384443003: Add scalar lowering for sqrt intrinsic. (Closed)

Created:
6 years, 5 months ago by jvoung (off chromium)

Modified:
6 years, 5 months ago

Reviewers:
Jim Stichnoth, wala

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

Add scalar lowering for sqrt intrinsic. Re-used test_arith_main.cpp, mostly to share the set of interesting floating point constants. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3882 R=stichnot@chromium.org, wala@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f37fbbe

Patch Set 2 : check dropping too #

Patch Set 4 : whitespace #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -6 lines)			Patch
M	crosstest/runtests.sh	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	crosstest/test_arith.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	crosstest/test_arith_main.cpp	View		4 chunks	+21 lines, -2 lines	0 comments	Download
A	crosstest/test_arith_sqrt.ll	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	crosstest/test_fcmp_main.cpp	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/IceInstX8632.h	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	src/IceInstX8632.cpp	View	1 2 3	2 chunks	+24 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll	View	1	2 chunks	+59 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

https://codereview.chromium.org/384443003/diff/10011/crosstest/runtests.sh File crosstest/runtests.sh (right): https://codereview.chromium.org/384443003/diff/10011/crosstest/runtests.sh#newcode35 crosstest/runtests.sh:35: --test=test_arith_sqrt.ll \ Or I could make it a separate ...

6 years, 5 months ago (2014-07-09 20:18:03 UTC) #1

Jim Stichnoth

LGTM. And thanks for the extra FP constants in other tests. :)

6 years, 5 months ago (2014-07-09 22:33:11 UTC) #3

jvoung (off chromium)

6 years, 5 months ago (2014-07-09 23:13:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as rf37fbbe (presubmit successful).

Expand Messages | Collapse Messages