Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: chrome/browser/ui/crypto_module_delegate_nss.cc

Issue 384413004: Remove default key slot from KeygenHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing android_webview. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/crypto_module_delegate_nss.h" 5 #include "chrome/browser/ui/crypto_module_delegate_nss.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "chrome/browser/net/nss_context.h"
10 #include "content/public/browser/browser_thread.h" 9 #include "content/public/browser/browser_thread.h"
11 10
12 using content::BrowserThread; 11 using content::BrowserThread;
13 12
14 ChromeNSSCryptoModuleDelegate::ChromeNSSCryptoModuleDelegate( 13 ChromeNSSCryptoModuleDelegate::ChromeNSSCryptoModuleDelegate(
15 chrome::CryptoModulePasswordReason reason, 14 chrome::CryptoModulePasswordReason reason,
16 const net::HostPortPair& server) 15 const net::HostPortPair& server)
17 : reason_(reason), 16 : reason_(reason),
18 server_(server), 17 server_(server),
19 event_(false, false), 18 event_(false, false),
20 cancelled_(false) {} 19 cancelled_(false) {}
21 20
22 ChromeNSSCryptoModuleDelegate::~ChromeNSSCryptoModuleDelegate() {} 21 ChromeNSSCryptoModuleDelegate::~ChromeNSSCryptoModuleDelegate() {}
23 22
24 bool ChromeNSSCryptoModuleDelegate::InitializeSlot(
25 content::ResourceContext* context,
26 const base::Closure& initialization_complete_callback) {
27 DCHECK_CURRENTLY_ON(BrowserThread::IO);
28 DCHECK(!slot_);
29 base::Callback<void(crypto::ScopedPK11Slot)> get_slot_callback;
30 if (!initialization_complete_callback.is_null())
31 get_slot_callback = base::Bind(&ChromeNSSCryptoModuleDelegate::DidGetSlot,
32 // Caller is responsible for keeping |this|
33 // alive until the callback is run.
34 base::Unretained(this),
35 initialization_complete_callback);
36
37 slot_ = GetPrivateNSSKeySlotForResourceContext(context, get_slot_callback);
38 return slot_.get() != NULL;
39 }
40
41 // TODO(mattm): allow choosing which slot to generate and store the key.
42 crypto::ScopedPK11Slot ChromeNSSCryptoModuleDelegate::RequestSlot() {
43 return slot_.Pass();
44 }
45
46 std::string ChromeNSSCryptoModuleDelegate::RequestPassword( 23 std::string ChromeNSSCryptoModuleDelegate::RequestPassword(
47 const std::string& slot_name, 24 const std::string& slot_name,
48 bool retry, 25 bool retry,
49 bool* cancelled) { 26 bool* cancelled) {
50 DCHECK(!event_.IsSignaled()); 27 DCHECK(!event_.IsSignaled());
51 event_.Reset(); 28 event_.Reset();
52 29
53 if (BrowserThread::PostTask( 30 if (BrowserThread::PostTask(
54 BrowserThread::UI, 31 BrowserThread::UI,
55 FROM_HERE, 32 FROM_HERE,
(...skipping 25 matching lines...) Expand all
81 } 58 }
82 59
83 void ChromeNSSCryptoModuleDelegate::GotPassword(const std::string& password) { 60 void ChromeNSSCryptoModuleDelegate::GotPassword(const std::string& password) {
84 if (!password.empty()) 61 if (!password.empty())
85 password_ = password; 62 password_ = password;
86 else 63 else
87 cancelled_ = true; 64 cancelled_ = true;
88 event_.Signal(); 65 event_.Signal();
89 } 66 }
90 67
91 void ChromeNSSCryptoModuleDelegate::DidGetSlot(const base::Closure& callback,
92 crypto::ScopedPK11Slot slot) {
93 DCHECK(!slot_);
94 slot_ = slot.Pass();
95 callback.Run();
96 }
97
98 crypto::CryptoModuleBlockingPasswordDelegate* 68 crypto::CryptoModuleBlockingPasswordDelegate*
99 CreateCryptoModuleBlockingPasswordDelegate( 69 CreateCryptoModuleBlockingPasswordDelegate(
100 chrome::CryptoModulePasswordReason reason, 70 chrome::CryptoModulePasswordReason reason,
101 const net::HostPortPair& server) { 71 const net::HostPortPair& server) {
102 // Returns a ChromeNSSCryptoModuleDelegate without calling InitializeSlot. 72 // Returns a ChromeNSSCryptoModuleDelegate without calling InitializeSlot.
103 // Since it is only being used as a CreateCryptoModuleBlockingDialogDelegate, 73 // Since it is only being used as a CreateCryptoModuleBlockingDialogDelegate,
104 // initializing the slot handle is unnecessary. 74 // initializing the slot handle is unnecessary.
105 return new ChromeNSSCryptoModuleDelegate(reason, server); 75 return new ChromeNSSCryptoModuleDelegate(reason, server);
106 } 76 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698