Source/core/html/HTMLTitleElement.cpp - Issue 384413003: Document.title getter should return text of title element and setter should stop when head el…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTitleElement.cpp

Issue 384413003: Document.title getter should return text of title element and setter should stop when head el… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase and take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTitleElement.cpp

diff --git a/Source/core/html/HTMLTitleElement.cpp b/Source/core/html/HTMLTitleElement.cpp

index f1d1c4fb19ef8e53f21275ab4fa1ead73de71e4a..06b789fe7268d7cf6b75cb0d50d271f656d85552 100644

--- a/Source/core/html/HTMLTitleElement.cpp

+++ b/Source/core/html/HTMLTitleElement.cpp

@@ -50,7 +50,7 @@ Node::InsertionNotificationRequest HTMLTitleElement::insertedInto(ContainerNode*

{

HTMLElement::insertedInto(insertionPoint);

if (inDocument() && !isInShadowTree())

- document().setTitleElement(text(), this);

+ document().setTitleElement(this);

return InsertionDone;

}

@@ -65,7 +65,7 @@ void HTMLTitleElement::childrenChanged(const ChildrenChange& change)

{

HTMLElement::childrenChanged(change);

if (inDocument() && !isInShadowTree() && !m_ignoreTitleUpdatesWhenChildrenChange)

- document().setTitleElement(text(), this);

+ document().setTitleElement(this);

}

String HTMLTitleElement::text() const

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/svg/SVGTitleElement.cpp » ('j') | no next file with comments »