Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 384413002: Gallery.app: Do not create images for each operation. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery.app: Do not create images for each operation. Previouslly the original flag of new item was not set correctly. BUG=393543 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ui/file_manager/gallery/js/gallery.js View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 5 months ago (2014-07-14 11:35:27 UTC) #1
yoshiki
lgtm
6 years, 5 months ago (2014-07-14 18:16:28 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-15 01:08:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/384413002/1
6 years, 5 months ago (2014-07-15 01:09:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 18:38:01 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 19:33:27 UTC) #6
Message was sent while issue was closed.
Change committed as 283237

Powered by Google App Engine
This is Rietveld 408576698