Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 384383002: Do not try to decrypt empty refresh token (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Do not try to decrypt empty refresh token Calling DecryptWithSystemSalt() with an empty string results in a WARNING in the log. BUG=393341 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/chromeos/settings/device_oauth2_token_service.cc View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
Julian, could you review this clean up change?
6 years, 5 months ago (2014-07-14 10:19:36 UTC) #1
pastarmovj
lgtm
6 years, 5 months ago (2014-07-14 10:58:10 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-14 11:27:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/384383002/1
6 years, 5 months ago (2014-07-14 11:27:59 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 14:11:24 UTC) #5
Message was sent while issue was closed.
Change committed as 282943

Powered by Google App Engine
This is Rietveld 408576698