Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 384353002: Removed spaces, fixed local storage mechanism for first time visit (Closed)

Created:
6 years, 5 months ago by jansson
Modified:
6 years, 5 months ago
Reviewers:
mcasas
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed spaces, fixed local storage mechanism for first time visit. Cleaned up a couple of spaces and also make sure the local storage mechanism handles first time visits by checking for null instead of 'undefined' since localStorage.getItem(key) returns null when it cannot find the key[1]. [1]http://www.w3.org/TR/webstorage/#dom-storage-getitem BUG=NONE TEST=Manual, setup P2P call NOTRY=TRUE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/test/data/webrtc/manual/peerconnection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webrtc/manual/peerconnection_manual.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jansson
Could you perform a wee code review? Just cleaned up a couple of spaces and ...
6 years, 5 months ago (2014-07-14 09:57:57 UTC) #1
mcasas
LGTM with nit: The description of the change should go in the CL description, not ...
6 years, 5 months ago (2014-07-14 12:50:13 UTC) #2
jansson
On 2014/07/14 12:50:13, mcasas wrote: > LGTM with nit: > > The description of the ...
6 years, 5 months ago (2014-07-14 12:59:39 UTC) #3
jansson
The CQ bit was checked by jansson@chromium.org
6 years, 5 months ago (2014-07-14 12:59:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jansson@chromium.org/384353002/1
6 years, 5 months ago (2014-07-14 13:01:08 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 13:02:15 UTC) #6
Message was sent while issue was closed.
Change committed as 282939

Powered by Google App Engine
This is Rietveld 408576698