Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 384303002: [fsp] Add support for copying files within a provided file system. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
benwells, hirono, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Add support for copying files within a provided file system. This CL adds support for copying files which are on the same provided file system. Note, that copying between file system instances will be done using FileStreamWriter. TEST=unit_tests, browser_tests: *FileSystemProvider*Copy* BUG=391362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284910

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -60 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc View 2 chunks +36 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/copy_entry.h View 3 chunks +12 lines, -12 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/copy_entry.cc View 2 chunks +14 lines, -11 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/copy_entry_unittest.cc View 1 4 chunks +43 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/file_system_provider/copy_entry/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/file_system_provider/copy_entry/test.js View 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mtomasz
CL almost identical to previous operations. @kinaba: PTAL at C++. @benwells: PTAL at IDL. @hirono: ...
6 years, 5 months ago (2014-07-14 05:03:31 UTC) #1
hirono
lgtm!
6 years, 5 months ago (2014-07-14 05:13:38 UTC) #2
kinaba
lgtm https://codereview.chromium.org/384303002/diff/1/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/384303002/diff/1/chrome/chrome_browser_chromeos.gypi#newcode396 chrome/chrome_browser_chromeos.gypi:396: 'browser/chromeos/file_system_provider/operations/copy_entry.h', sort ('cl' < 'co')
6 years, 5 months ago (2014-07-14 06:29:40 UTC) #3
mtomasz
https://codereview.chromium.org/384303002/diff/1/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/384303002/diff/1/chrome/chrome_browser_chromeos.gypi#newcode396 chrome/chrome_browser_chromeos.gypi:396: 'browser/chromeos/file_system_provider/operations/copy_entry.h', On 2014/07/14 06:29:39, kinaba wrote: > sort ('cl' ...
6 years, 5 months ago (2014-07-14 08:51:43 UTC) #4
mtomasz
On 2014/07/14 08:51:43, mtomasz wrote: > https://codereview.chromium.org/384303002/diff/1/chrome/chrome_browser_chromeos.gypi > File chrome/chrome_browser_chromeos.gypi (right): > > https://codereview.chromium.org/384303002/diff/1/chrome/chrome_browser_chromeos.gypi#newcode396 > ...
6 years, 5 months ago (2014-07-16 00:22:57 UTC) #5
benwells
lgtm
6 years, 5 months ago (2014-07-21 00:54:10 UTC) #6
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-21 03:17:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/384303002/20001
6 years, 5 months ago (2014-07-21 03:18:18 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 03:29:20 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 03:30:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/30913)
6 years, 5 months ago (2014-07-21 03:30:48 UTC) #11
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-23 07:52:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/384303002/60001
6 years, 5 months ago (2014-07-23 07:52:38 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 09:49:58 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 14:07:40 UTC) #15
Message was sent while issue was closed.
Change committed as 284910

Powered by Google App Engine
This is Rietveld 408576698