Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 384273003: Move multipart_response_delegate.* from webkit/ to content/ (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
jam, boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam, darin2, pilgrim_google, jamesr, jochen (gone - plz use gerrit), Torne
Project:
chromium
Visibility:
Public.

Description

Move multipart_response_delegate.* from webkit/ to content/ Put MultipartResponseDelegate into content namespace while at it. BUG=338338 TEST=content_unittests R=jam@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283427

Patch Set 1 #

Patch Set 2 : android_webview fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -604 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/child/multipart_response_delegate.h View 4 chunks +7 lines, -12 lines 0 comments Download
A + content/child/multipart_response_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/multipart_response_delegate_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 3 chunks +1 line, -2 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 2 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M webkit/child/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/child/multipart_response_delegate.h View 1 chunk +0 lines, -155 lines 0 comments Download
D webkit/child/multipart_response_delegate.cc View 1 chunk +0 lines, -404 lines 0 comments Download
M webkit/child/webkit_child.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tfarina
6 years, 5 months ago (2014-07-14 03:10:39 UTC) #1
tfarina
+boliu for android_webview checklicenses issue. :/
6 years, 5 months ago (2014-07-14 03:36:47 UTC) #2
boliu
On 2014/07/14 03:36:47, tfarina wrote: > +boliu for android_webview checklicenses issue. :/ You need to ...
6 years, 5 months ago (2014-07-14 03:40:00 UTC) #3
jam
lgtm
6 years, 5 months ago (2014-07-15 00:36:08 UTC) #4
tfarina
boliu, ptal.
6 years, 5 months ago (2014-07-15 00:52:33 UTC) #5
boliu
On 2014/07/15 00:52:33, tfarina wrote: > boliu, ptal. lgtm
6 years, 5 months ago (2014-07-15 00:53:25 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-15 09:59:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/384273003/20001
6 years, 5 months ago (2014-07-15 10:01:02 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 22:23:21 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 22:41:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/39142)
6 years, 5 months ago (2014-07-15 22:41:50 UTC) #11
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-16 12:51:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/384273003/20001
6 years, 5 months ago (2014-07-16 12:52:39 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:02:28 UTC) #14
Message was sent while issue was closed.
Change committed as 283427

Powered by Google App Engine
This is Rietveld 408576698