Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 384263002: ui: Move screen unit test into gfx_unittests target. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

ui: Move screen unit test into gfx_unittests target. This is pretty straightforward, just moving the screen_unittest.cc entries from ui_unittests.gyp to gfx_tests.gyp. gfx_unittests now has a TestSuite that setups everything we need to run it. BUG=331829 TEST=ui_unittests, gfx_unittests TBR=ben@chromium.org,danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284458

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/gfx/gfx_tests.gyp View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/ui_unittests.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
TBRing....
6 years, 5 months ago (2014-07-21 15:52:38 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-21 15:52:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/384263002/20001
6 years, 5 months ago (2014-07-21 15:53:56 UTC) #3
commit-bot: I haz the power
Change committed as 284458
6 years, 5 months ago (2014-07-21 18:02:08 UTC) #4
Ben Goodger (Google)
6 years, 5 months ago (2014-07-23 15:58:59 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698