Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 384243004: Make <a ping> work for context menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 7f05db586db58ce7b7c414b9d101da3f18a82f67..adeff7036a909ee17b3c03e591a29b0cf2850462 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1012,6 +1012,12 @@ void RenderFrameImpl::OnContextMenuClosed(
pending_context_menus_.Remove(custom_context.request_id);
}
} else {
+ if (custom_context.link_followed.is_valid()) {
+ frame_->sendPings(
+ ContextMenuParamsBuilder::extractParentAnchorNode(
darin (slow to review) 2014/07/22 17:34:40 maybe we should just have a dom_utils.{h,cc} in co
Nate Chapin 2014/07/22 18:19:56 Agree. dom_utils.{h,cc} seems like a reasonable na
+ context_menu_node_),
+ custom_context.link_followed);
+ }
// Internal request, forward to WebKit.
context_menu_node_.reset();
}

Powered by Google App Engine
This is Rietveld 408576698