content/renderer/context_menu_params_builder.h - Issue 384243004: Make <a ping> work for context menus.

Side by Side Diff: content/renderer/context_menu_params_builder.h

Issue 384243004: Make <a ping> work for context menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/public/common/context_menu_params.h ('K') | « content/public/common/context_menu_params.h ('k') | content/renderer/context_menu_params_builder.cc » ('j') | content/renderer/context_menu_params_builder.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_RENDERER_CONTEXT_MENU_PARAMS_BUILDER_H_	5 #ifndef CONTENT_RENDERER_CONTEXT_MENU_PARAMS_BUILDER_H_

6 #define CONTENT_RENDERER_CONTEXT_MENU_PARAMS_BUILDER_H_	6 #define CONTENT_RENDERER_CONTEXT_MENU_PARAMS_BUILDER_H_

7	7

8 namespace blink {	8 namespace blink {

9 struct WebContextMenuData;	9 struct WebContextMenuData;

	10 class WebNode;

10 }	11 }

11	12

12 namespace content {	13 namespace content {

13 struct ContextMenuParams;	14 struct ContextMenuParams;

14	15

15 class ContextMenuParamsBuilder {	16 class ContextMenuParamsBuilder {

16 public:	17 public:

17 static ContextMenuParams Build(const blink::WebContextMenuData& data);	18 static ContextMenuParams Build(const blink::WebContextMenuData& data);

	19

	20 static blink::WebNode extractParentAnchorNode(const blink::WebNode& node);
	Nate Chapin 2014/07/14 19:01:46 WebContextMenuData provides the deepest WebNode th WebContextMenuData provides the deepest WebNode that was clicked for the context menu. Since that can be a text node for a clicked link, we need a way to walk up the DOM, looking for a parent that is actually an <a>. This logic is extracted from Build(). darin (slow to review) 2014/07/22 17:34:39 You should probably add some comments on this func Show quoted text On 2014/07/14 19:01:46, Nate Chapin wrote: > WebContextMenuData provides the deepest WebNode that was clicked for the context > menu. Since that can be a text node for a clicked link, we need a way to walk up > the DOM, looking for a parent that is actually an <a>. This logic is extracted > from Build(). You should probably add some comments on this function. However, I'm not sure this function really has that much to do with ContextMenuParamsBuilder. Is this the best place for this function to live? darin (slow to review) 2014/07/22 17:34:40 nit: extract -> Extract nit: extract -> Extract Nate Chapin 2014/07/22 18:19:56 Done. Show quoted text On 2014/07/22 17:34:40, darin wrote: > nit: extract -> Extract Done. Nate Chapin 2014/07/22 18:19:56 Done. Show quoted text On 2014/07/22 17:34:39, darin wrote: > On 2014/07/14 19:01:46, Nate Chapin wrote: > > WebContextMenuData provides the deepest WebNode that was clicked for the > context > > menu. Since that can be a text node for a clicked link, we need a way to walk > up > > the DOM, looking for a parent that is actually an <a>. This logic is extracted > > from Build(). > > You should probably add some comments on this function. However, I'm not sure > this function really has that much to do with ContextMenuParamsBuilder. Is this > the best place for this function to live? Done.
18 };	21 };

19	22

20 } // namespace content	23 } // namespace content

21	24

22 #endif // CONTENT_RENDERER_CONTEXT_MENU_PARAMS_BUILDER_H_	25 #endif // CONTENT_RENDERER_CONTEXT_MENU_PARAMS_BUILDER_H_

OLD	NEW