Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 384233002: Always have GrLayer's rect be valid (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Always have GrLayer's rect be valid This CL just makes atlasing easier/clearer since there is a separate atlased query method. Not using the rect as a signal also simplifies the rendering of the layer in SkGpuDevice.cpp. This is calved off from (Add atlased layer purging - https://codereview.chromium.org/367073002/) Committed: https://skia.googlesource.com/skia/+/21048b588faa6a1c84949603ba82d9d4ba2f0cdd

Patch Set 1 #

Patch Set 2 : Fix newlines #

Patch Set 3 : More cleanup #

Patch Set 4 : Fix bug #

Patch Set 5 : Fix use of deprecated function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -48 lines) Patch
M src/gpu/GrLayerCache.h View 1 2 3 4 chunks +20 lines, -8 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 2 3 4 chunks +75 lines, -7 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 3 chunks +19 lines, -28 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-14 20:38:16 UTC) #1
bsalomon
lgtm
6 years, 5 months ago (2014-07-15 13:51:24 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-15 13:54:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/384233002/60001
6 years, 5 months ago (2014-07-15 13:54:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-07-15 14:09:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 14:12:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/builds/1889)
6 years, 5 months ago (2014-07-15 14:12:50 UTC) #7
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-15 14:33:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/384233002/80001
6 years, 5 months ago (2014-07-15 14:34:10 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 02:46:39 UTC) #10
Message was sent while issue was closed.
Change committed as 21048b588faa6a1c84949603ba82d9d4ba2f0cdd

Powered by Google App Engine
This is Rietveld 408576698