Issue 384149: Fix intermittent DCHECK failure in BlacklistManagerTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384149: Fix intermittent DCHECK failure in BlacklistManagerTest. (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
jam, dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Fix intermittent DCHECK failure in BlacklistManagerTest. Ensure correct shutdown of threads. TEST=Covered by unit_tests. BUG=27726 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32090

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

dank

I can't reproduce the DCHECK on this system even without the patch, but the patch ...

11 years, 1 month ago (2009-11-16 17:12:17 UTC) #2

lgtm