Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 384143002: Remove unused variable orig_size. (Closed)

Created:
6 years, 5 months ago by halyavin
Modified:
6 years, 5 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Remove unused variable orig_size. Original patch by Andrey Khalyavin <halyavin@google.com>; BUG=N/A

Patch Set 1 #

Patch Set 2 : try to upload again #

Patch Set 3 : Change description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 4 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
halyavin
My editor removes trailing spaces automatically, hence the extra diff.
6 years, 5 months ago (2014-07-12 19:35:03 UTC) #1
Bo Xu
On 2014/07/12 19:35:03, halyavin wrote: > My editor removes trailing spaces automatically, hence the extra ...
6 years, 5 months ago (2014-07-14 17:25:41 UTC) #2
halyavin
Can you commit it, please?
6 years, 5 months ago (2014-07-16 16:28:15 UTC) #3
Bo Xu
On 2014/07/16 16:28:15, halyavin wrote: > Can you commit it, please? Sure. I can not ...
6 years, 5 months ago (2014-07-16 16:53:14 UTC) #4
halyavin
Done. For some reason git-cl upload doesn't change description so I edited it through web-interface. ...
6 years, 5 months ago (2014-07-16 17:53:00 UTC) #5
Bo Xu
On 2014/07/16 17:53:00, halyavin wrote: > Done. For some reason git-cl upload doesn't change description ...
6 years, 5 months ago (2014-07-16 23:33:12 UTC) #6
Bo Xu
6 years, 5 months ago (2014-07-18 02:19:30 UTC) #7
On 2014/07/16 23:33:12, Bo Xu wrote:
> On 2014/07/16 17:53:00, halyavin wrote:
> > Done. For some reason git-cl upload doesn't change description so I edited
it
> > through web-interface. It adds superficial ; for some reason.
> 
> Thanks. Commit done.

halyavin, I guess you have to manually close this issue.

Powered by Google App Engine
This is Rietveld 408576698