Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 384130: For Mstone-4: Improve URL Logging in crash reporting (Closed)

Created:
11 years, 1 month ago by jschuh
Modified:
9 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam
Visibility:
Public.

Description

Duplicating the SetActiveURL() change from the renderer to the plugin process. (Should also fix a plugin callback that may be clearing the renderer's URL prematurely.) BUG=22033 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/plugin/npobject_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jschuh
Sorry to slip this in late on Friday, but I wanted to collect some data ...
11 years, 1 month ago (2009-11-13 22:28:27 UTC) #1
cpu_(ooo_6.6-7.5)
11 years, 1 month ago (2009-11-13 23:18:29 UTC) #2
LGTM

Talk to LaForge to make the case this needs to be included.

Powered by Google App Engine
This is Rietveld 408576698