Mac: Draw download item background like windows does if a theme is installed.

Draw download item background like windows does if a theme is installed.

BUG=27221
TEST=Download something, install theme. Download item should look different.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31907

[Avi (use Gerrit), 2009-11-13 16:13:59]

LG

http://codereview.chromium.org/384115/diff/1/3
File chrome/browser/cocoa/download_item_cell.mm (right):

http://codereview.chromium.org/384115/diff/1/3#newcode336
Line 336: alpha:51/255.0];
File a bug to get these colors from the theme. We shouldn't be hard-coding
colors everywhere :(

[Nico, 2009-11-13 16:23:07]

http://codereview.chromium.org/384115/diff/1/3
File chrome/browser/cocoa/download_item_cell.mm (right):

http://codereview.chromium.org/384115/diff/1/3#newcode336
Line 336: alpha:51/255.0];
On 2009/11/13 16:13:59, Avi wrote:
> File a bug to get these colors from the theme. We shouldn't be hard-coding
> colors everywhere :(

No, these colors should be hardcoded. If the current theme is not the default
theme, we always want these fixed colors, no matter the theme.

[Avi (use Gerrit), 2009-11-13 16:27:43]

On 2009/11/13 16:23:07, Nico wrote:
> > File a bug to get these colors from the theme.
> No, these colors should be hardcoded. If the current theme is not the default
> theme, we always want these fixed colors, no matter the theme.

Sorry about my imprecise wording. File a bug to get these colors from the
GTMTheme. IMO, the code should really have one code path, to get drawing info
from the GTMTheme, which should know what it's doing.

[Nico, 2009-11-13 16:43:16]

Filed http://crbug.com/27625

On Fri, Nov 13, 2009 at 8:27 AM,  <avi@chromium.org> wrote:
> On 2009/11/13 16:23:07, Nico wrote:
>>
>> > File a bug to get these colors from the theme.
>> No, these colors should be hardcoded. If the current theme is not the
>> default
>> theme, we always want these fixed colors, no matter the theme.
>
> Sorry about my imprecise wording. File a bug to get these colors from the
> GTMTheme. IMO, the code should really have one code path, to get drawing
> info
> from the GTMTheme, which should know what it's doing.
>
> http://codereview.chromium.org/384115
>