Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4116)

Unified Diff: chrome/browser/cocoa/toolbar_controller_unittest.mm

Issue 384105: Mac: Animate the bookmark bar showing/hiding. (Closed)
Patch Set: Comments added per rohitrao's review. Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/toolbar_controller.mm ('k') | chrome/browser/cocoa/view_resizer_pong.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/toolbar_controller_unittest.mm
diff --git a/chrome/browser/cocoa/toolbar_controller_unittest.mm b/chrome/browser/cocoa/toolbar_controller_unittest.mm
index 5c731fd32512512a38188dc405f64c954deeed15..37b20cb934baab67f7735299e93cab48f5d2df14 100644
--- a/chrome/browser/cocoa/toolbar_controller_unittest.mm
+++ b/chrome/browser/cocoa/toolbar_controller_unittest.mm
@@ -296,14 +296,11 @@ TEST_F(ToolbarControllerTest, PopulateEncodingMenu) {
EXPECT_NE(0, [encodings numberOfItems]);
}
-TEST_F(ToolbarControllerTest, CorrectHeightWhenCompressed) {
- [bar_ setShouldBeCompressed:YES];
- EXPECT_EQ(30.0, [resizeDelegate_ height]);
-}
-
-TEST_F(ToolbarControllerTest, CorrectHeightWhenUnompressed) {
- [bar_ setShouldBeCompressed:NO];
- EXPECT_EQ(36.0, [resizeDelegate_ height]);
+TEST_F(ToolbarControllerTest, HeightCompression) {
+ for (int i = 0; i <= 10; i++) {
+ [bar_ setHeightCompression:static_cast<CGFloat>(i)];
+ EXPECT_EQ(static_cast<CGFloat>(36 - i), [resizeDelegate_ height]);
+ }
}
} // namespace
« no previous file with comments | « chrome/browser/cocoa/toolbar_controller.mm ('k') | chrome/browser/cocoa/view_resizer_pong.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698